Dataverse collection linking/unlinking without superuser status by vera · Pull Request #12250 · IQSS/dataverse

vera · 2026-03-24T10:57:01Z

What this PR does / why we need it:

Dataverse collection linking and unlinking no longer requires superuser status. Users with the "Link Dataverse" permission on a collection can now perform these actions through both the UI and API.

This change follows up on the introduction of the "Link Dataverse" permission. Previously, even with this permission, only superusers could actually perform linking actions, as reported in #12076.

Removed the superuser requirement for linking and unlinking Dataverse collections. (Updated the LinkDataverseCommand and DeleteDataverseLinkingDataverseCommand to use the LinkDataverse permission instead of a superuser check.)
Enabled the "Link" button in the Dataverse collection UI for non-superusers.
Updated documentation and integration tests to reflect these changes.
Fixed a bug in the linking service and API (discovered during testing) where the "linking" and "linked" collections were being mixed up during lookups and deletions.

Which issue(s) this PR closes:

Closes Dataverse linking still requires superuser despite introduction of LinkDataverse permission #12076

Special notes for your reviewer:

/

Suggestions on how to test this:

I've updated the following test:

mvn test -Dtest="LinkIT#testCreateDeleteDataverseLink"

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

I added a release note

Additional documentation:

/

…tions via API (no superuser)

…ng + unlinking

…collection links

sekmiller · 2026-05-11T19:14:10Z

There's a method in the Dataverse page that makes a list of Dataverses available to be linked to - updateLinkableDataverses. It is still considering all dataverses for this list since linking was a superuser only function. Now that non-superusers are allowed it should be changed to include only those Dataverses that the user has permission on. As is - if the non-super user picks a dataverse from this list that they do not have permission on the link will fail and an "internal error" is posted to the UI

pdurbin · 2026-06-05T10:01:57Z

@srmanda-cs this is a case where there's a failure in Jenkins (MoveIT) but not GitHub Actions. Strange.

@vera a related issue:

Let contributors know why tests are failing #9916

pdurbin · 2026-06-05T10:04:54Z

@vera here's the line number:

ashmanda-cs · 2026-06-05T10:24:30Z

@srmanda-cs this is a case where there's a failure in Jenkins (MoveIT) but not GitHub Actions. Strange.

@vera a related issue:

Let contributors know why tests are failing #9916

vera · 2026-06-05T10:28:00Z

Thanks @pdurbin ! That is strange. I've run the test multiple times locally and never got a failure.

Looking at the test code, I suspect it may be a timing-related issue and not necessarily related to a change in this PR. The move with forceMove=true deletes the dataset link, but the DatasetLinkingDataverse record might still exist in the database when the test's next API call (getLinksAfter) is made, if the call is made too quickly.

ashmanda-cs · 2026-06-05T10:50:07Z

could you try rebasing the branch on develop and see if that fixes it?

…inking

vera · 2026-06-05T12:45:47Z

could you try rebasing the branch on develop and see if that fixes it?

Everything seems to be OK now 👍

ashmanda-cs · 2026-06-05T13:03:29Z

I triggered a rebuild on Jenkins, let's see.

ashmanda-cs · 2026-06-05T14:28:36Z

New failures

testImportDDI – edu.harvard.iq.dataverse.api.DataversesIT
9s
Error
expected: <201> but was: <500>
Stacktrace
org.opentest4j.AssertionFailedError: expected: <201> but was: <500>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
	at edu.harvard.iq.dataverse.api.DataversesIT.testImportDDI(DataversesIT.java:700)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Standard Output
{
    "status": "OK",
    "data": {
        "id": 89,
        "persistentId": "doi:10.5072/FK2/N5OQ7A"
    }
}
{
    "status": "OK",
    "data": {
        "id": 90,
        "persistentId": "doi:10.5072/FK2/ABCD11"
    }
}
{
    "status": "OK",
    "data": {
        "id": 91,
        "persistentId": "doi:10.5072/FK2/ABCD22",
        "releaseCompleted": false
    }
}
{
    "status": "ERROR",
    "message": "Command [DatasetCreate dataset:null] failed: Exception thrown from bean: jakarta.persistence.PersistenceException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 5.0.0-B08.payara-p1.v202511041741-60b8f7dca8141786130b4d36785fdcc926eb8cff): org.eclipse.persistence.exceptions.DatabaseException\nInternal Exception: java.sql.SQLException: Connection closed\nError Code: 0\nCall: select lastval()\nQuery: ValueReadQuery(name=\"SEQ_GEN_IDENTITY\" sql=\"select lastval()\")"
}
Standard Error
Jun 05, 2026 1:49:56 PM edu.harvard.iq.dataverse.api.UtilIT createRandomUser
INFO: Creating random test user user6ca4c46a
Jun 05, 2026 1:49:57 PM edu.harvard.iq.dataverse.api.UtilIT getUsernameFromResponse
INFO: Username found in create user response: user6ca4c46a
Jun 05, 2026 1:49:57 PM edu.harvard.iq.dataverse.api.UtilIT getApiTokenFromResponse
INFO: API token found in create user response: 5467f01d-32e0-4e50-99fa-94862705191f
Jun 05, 2026 1:49:57 PM edu.harvard.iq.dataverse.api.UtilIT getAliasFromResponse
INFO: Alias found in create dataverse response: dv1b7db537
Jun 05, 2026 1:49:58 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetDDIViaNativeApi
INFO: Here importDatasetDDIViaNativeApi
Jun 05, 2026 1:49:58 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetDDIViaNativeApi
INFO: /api/dataverses/dv1b7db537/datasets/:importddi
Jun 05, 2026 1:49:58 PM edu.harvard.iq.dataverse.api.DataversesIT testImportDDI
INFO: {
    "status": "OK",
    "data": {
        "id": 89,
        "persistentId": "doi:10.5072/FK2/N5OQ7A"
    }
}
Jun 05, 2026 1:49:58 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetDDIViaNativeApi
INFO: Here importDatasetDDIViaNativeApi
Jun 05, 2026 1:49:58 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetDDIViaNativeApi
INFO: /api/dataverses/dv1b7db537/datasets/:importddi?pid=doi:10.5072/FK2/ABCD11
Jun 05, 2026 1:50:01 PM edu.harvard.iq.dataverse.api.DataversesIT testImportDDI
INFO: {
    "status": "OK",
    "data": {
        "id": 90,
        "persistentId": "doi:10.5072/FK2/ABCD11"
    }
}
Jun 05, 2026 1:50:01 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetDDIViaNativeApi
INFO: Here importDatasetDDIViaNativeApi
Jun 05, 2026 1:50:01 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetDDIViaNativeApi
INFO: /api/dataverses/dv1b7db537/datasets/:importddi?pid=doi:10.5072/FK2/ABCD22&release=yes
Jun 05, 2026 1:50:03 PM edu.harvard.iq.dataverse.api.DataversesIT testImportDDI
INFO: {
    "status": "OK",
    "data": {
        "id": 91,
        "persistentId": "doi:10.5072/FK2/ABCD22",
        "releaseCompleted": false
    }
}
Jun 05, 2026 1:50:03 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetDDIViaNativeApi
INFO: Here importDatasetDDIViaNativeApi
Jun 05, 2026 1:50:03 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetDDIViaNativeApi
INFO: /api/dataverses/dv1b7db537/datasets/:importddi?release=yes
Jun 05, 2026 1:50:05 PM edu.harvard.iq.dataverse.api.DataversesIT testImportDDI
INFO: {
    "status": "ERROR",
    "message": "Command [DatasetCreate dataset:null] failed: Exception thrown from bean: jakarta.persistence.PersistenceException: Exception [EclipseLink-4002] (Eclipse Persistence Services - 5.0.0-B08.payara-p1.v202511041741-60b8f7dca8141786130b4d36785fdcc926eb8cff): org.eclipse.persistence.exceptions.DatabaseException\nInternal Exception: java.sql.SQLException: Connection closed\nError Code: 0\nCall: select lastval()\nQuery: ValueReadQuery(name=\"SEQ_GEN_IDENTITY\" sql=\"select lastval()\")"
}

---

testImport – edu.harvard.iq.dataverse.api.DataversesIT
<1s
Error
expected: <201> but was: <403>
Stacktrace
org.opentest4j.AssertionFailedError: expected: <201> but was: <403>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
	at edu.harvard.iq.dataverse.api.DataversesIT.testImport(DataversesIT.java:1122)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Standard Output
{
    "status": "ERROR",
    "message": "Please provide a persistent identifier, either by including it in the JSON, or by using the pid query parameter."
}
{
    "status": "ERROR",
    "message": "Please provide a persistent identifier, either by including it in the JSON, or by using the pid query parameter."
}
{
    "status": "ERROR",
    "message": "Cannot import a dataset that has a PID that doesn't match the server's settings"
}
{
    "status": "ERROR",
    "message": "Persistent identifier doi:10.5072/FK2/ABCD11 already exists in this Dataverse installation."
}
Standard Error
Jun 05, 2026 1:50:32 PM edu.harvard.iq.dataverse.api.UtilIT createRandomUser
INFO: Creating random test user user790c84f0
Jun 05, 2026 1:50:32 PM edu.harvard.iq.dataverse.api.UtilIT getUsernameFromResponse
INFO: Username found in create user response: user790c84f0
Jun 05, 2026 1:50:32 PM edu.harvard.iq.dataverse.api.UtilIT getApiTokenFromResponse
INFO: API token found in create user response: 598ad6fe-f2e9-46ca-817a-36243cd05c3e
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.UtilIT getAliasFromResponse
INFO: Alias found in create dataverse response: dv676c49a6
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetViaNativeApi
INFO: Here importDatasetViaNativeApi
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetViaNativeApi
INFO: /api/dataverses/dv676c49a6/datasets/:import
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.DataversesIT testImport
INFO: {
    "status": "ERROR",
    "message": "Please provide a persistent identifier, either by including it in the JSON, or by using the pid query parameter."
}
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetViaNativeApi
INFO: Here importDatasetViaNativeApi
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetViaNativeApi
INFO: /api/dataverses/dv676c49a6/datasets/:import?release=yes
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.DataversesIT testImport
INFO: {
    "status": "ERROR",
    "message": "Please provide a persistent identifier, either by including it in the JSON, or by using the pid query parameter."
}
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetViaNativeApi
INFO: Here importDatasetViaNativeApi
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetViaNativeApi
INFO: /api/dataverses/dv676c49a6/datasets/:import?pid=doi:10.5073/FK2/ABCD11
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.DataversesIT testImport
INFO: {
    "status": "ERROR",
    "message": "Cannot import a dataset that has a PID that doesn't match the server's settings"
}
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetViaNativeApi
INFO: Here importDatasetViaNativeApi
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.UtilIT importDatasetViaNativeApi
INFO: /api/dataverses/dv676c49a6/datasets/:import?pid=doi:10.5072/FK2/ABCD11
Jun 05, 2026 1:50:33 PM edu.harvard.iq.dataverse.api.DataversesIT testImport
INFO: {
    "status": "ERROR",
    "message": "Persistent identifier doi:10.5072/FK2/ABCD11 already exists in this Dataverse installation."
}

vera · 2026-06-11T09:22:09Z

Strange, I ran DataversesIT locally and I'm not seeing those two test cases fail.

I also ran DataversesIT#testImportDDI and DataversesIT#testImport separately and they passed. I can try and take a closer look later but right now I'm unsure what's going on. Btw the CI pipeline seems to be passing as well, right? Is it another case of flakey tests?

pdurbin · 2026-06-11T11:05:19Z

Yeah, probably flaky tests. All API tests are passing in both CI systems as of this writing.

pdurbin · 2026-07-09T14:14:59Z

Merging this PR may have caused complications with this one:

Feature: Extend Search API to include isLinked #12485

@stevenwinship found two bugs in this PR (#12250), which he has fixed in the PR above. See this commit: fe2c8ad

Conflicts with IQSS#12250: src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java

Revert PR #12250 - feat/non-superuser-dataverse-linking

pdurbin · 2026-09-09T17:57:50Z

We had to revert this PR. I put some details here: #12076 (comment)

…taverse-linking" This reverts commit 16ea4cc, reversing changes made to 0df5da7.

vera mentioned this pull request Mar 24, 2026

Dataverse linking still requires superuser despite introduction of LinkDataverse permission #12076

Open

pdurbin added this to IQSS Dataverse Project Mar 24, 2026

pdurbin moved this to Ready for Triage in IQSS Dataverse Project Mar 24, 2026

scolapasta moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Mar 24, 2026

cmbz added the FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) label Mar 27, 2026

vera added 6 commits April 2, 2026 10:16

feat: require only LinkDataverse permission to link and unlink collec…

9476a41

…tions via API (no superuser)

feat: show "Link" button for collections in UI to non-superusers

17e4829

docs: add/update docs about linking

a752d33

test: update LinkIT to test required permissions for collection linki…

837cf5d

…ng + unlinking

fix: fix mix-up of linking + linked collection when finding/deleting …

6ce0b91

…collection links

docs: add release note for IQSS#12076

02ae1be

pdurbin force-pushed the feat/non-superuser-dataverse-linking branch from dce93ce to 02ae1be Compare April 2, 2026 14:16

stevenwinship self-assigned this Apr 2, 2026

stevenwinship moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 2, 2026

stevenwinship reviewed Apr 2, 2026

View reviewed changes

Comment thread doc/sphinx-guides/source/api/native-api.rst Outdated

stevenwinship reviewed Apr 2, 2026

View reviewed changes

Comment thread doc/sphinx-guides/source/api/native-api.rst Outdated

stevenwinship reviewed Apr 2, 2026

View reviewed changes

Comment thread doc/sphinx-guides/source/api/native-api.rst Outdated

stevenwinship assigned vera Apr 2, 2026

cmbz added the FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) label Apr 8, 2026

docs: add missing indentation to docs about linking

2795446

stevenwinship approved these changes Apr 10, 2026

View reviewed changes

github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 10, 2026

stevenwinship unassigned vera and stevenwinship Apr 10, 2026

cmbz added the FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) label Apr 22, 2026

cmbz added the FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) label May 6, 2026

sekmiller self-assigned this May 11, 2026

sekmiller moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project May 11, 2026

jp-tosca added the Status: Needs Input Applied to issues in need of input from someone currently unavailable label May 18, 2026

Merge branch 'refs/heads/develop' into feat/non-superuser-dataverse-l…

9af0c8c

…inking

sekmiller merged commit 16ea4cc into IQSS:develop Jul 8, 2026
16 checks passed

github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jul 8, 2026

github-project-automation Bot moved this from 🔍 Interest to Done in Recherche Data Gouv Jul 8, 2026

pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jul 8, 2026

pdurbin added this to the 6.12 milestone Jul 8, 2026

pdurbin moved this from Done 🧹 to Merged 🚀 in IQSS Dataverse Project Jul 8, 2026

pdurbin assigned pdurbin and unassigned sekmiller and vera Jul 8, 2026

pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jul 9, 2026

pdurbin removed their assignment Jul 9, 2026

stevenwinship mentioned this pull request Jul 9, 2026

Feature: Extend Search API to include isLinked #12485

Open

pdurbin added a commit to beepsoft/dataverse that referenced this pull request Jul 10, 2026

Merge branch 'develop' into openapi-improvements

91762b2

Conflicts with IQSS#12250: src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java

pdurbin mentioned this pull request Sep 9, 2026

Revert PR #12250 - feat/non-superuser-dataverse-linking #12674

Merged

ErykKul mentioned this pull request Sep 9, 2026

Cache and bound the collection page link check #12672 #12675

Open

landreev added a commit that referenced this pull request Sep 9, 2026

Merge pull request #12674 from IQSS/12672-revert-pr12250

e612570

Revert PR #12250 - feat/non-superuser-dataverse-linking

ashmanda-cs pushed a commit to uncch-rdmc/dataverse that referenced this pull request Sep 9, 2026

Revert "Merge pull request IQSS#12250 from vera/feat/non-superuser-da…

d6598cc

…taverse-linking" This reverts commit 16ea4cc, reversing changes made to 0df5da7.

Uh oh!

Conversation

vera commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sekmiller commented May 11, 2026

Uh oh!

pdurbin commented Jun 5, 2026

Uh oh!

pdurbin commented Jun 5, 2026

Uh oh!

ashmanda-cs commented Jun 5, 2026

Uh oh!

vera commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashmanda-cs commented Jun 5, 2026

Uh oh!

vera commented Jun 5, 2026

Uh oh!

ashmanda-cs commented Jun 5, 2026

Uh oh!

ashmanda-cs commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vera commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pdurbin commented Jun 11, 2026

Uh oh!

Uh oh!

pdurbin commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pdurbin commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

vera commented Mar 24, 2026 •

edited

Loading

vera commented Jun 5, 2026 •

edited

Loading

ashmanda-cs commented Jun 5, 2026 •

edited

Loading

vera commented Jun 11, 2026 •

edited

Loading

pdurbin commented Jul 9, 2026 •

edited

Loading