Skip to content

Brief datacite xml - #12662

Open
janvanmansum wants to merge 6 commits into
IQSS:developfrom
DANS-KNAW:brief-datacite-xml
Open

Brief datacite xml#12662
janvanmansum wants to merge 6 commits into
IQSS:developfrom
DANS-KNAW:brief-datacite-xml

Conversation

@janvanmansum

@janvanmansum janvanmansum commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Add an option to generate datacite.xml with fewer datafile specific elements.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:
You can see the resulting datacite.xml by looking at the metadata export for DataCite. You may need to reexport first, to avoid seeing an older, cached version of the file. See: https://guides.dataverse.org/en/latest/admin/metadataexport.html#batch-exports-through-the-api

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No

Is there a release notes update needed for this change?:
Yes, see: https://github.com/IQSS/dataverse/pull/12662/changes#diff-ea591f6967f307b36efb1e2ce30da90db2c09add68fb0283b84c96450ec5872a

Additional documentation:
None

Copilot AI and others added 5 commits September 1, 2026 16:23
Co-authored-by: janvanmansum <3862694+janvanmansum@users.noreply.github.com>
Co-authored-by: janvanmansum <3862694+janvanmansum@users.noreply.github.com>
Co-authored-by: janvanmansum <3862694+janvanmansum@users.noreply.github.com>
@janvanmansum
janvanmansum marked this pull request as ready for review September 3, 2026 10:24
@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Sep 8, 2026
@pdurbin pdurbin moved this from Ready for Triage to In Review 🔎 in IQSS Dataverse Project Sep 8, 2026
@pdurbin pdurbin added the Size: 10 A percentage of a sprint. 7 hours. label Sep 8, 2026
@cmbz cmbz added FY27 Sprint 5 FY27 Sprint 5 (2026-08-26 - 2026-09-09) FY27 Sprint 6 FY27 Sprint 6 (2026-09-09 - 2026-09-23) labels Sep 9, 2026
@qqmyers

qqmyers commented Sep 10, 2026

Copy link
Copy Markdown
Member

@janvanmansum - I'm starting to review this and have an initial question - since this is a new global setting, is it useful for some reason to pass it down through the DataCite class hierarchy, and to have methods w/ and w/o the param at multiple levels? It seems to me like it would be simpler to just read the new param as part of constructing the XmlMetadataTemplate (or even statically since its a constant during any Payara run). I think the only real change in functionality is that this would assure that the param is used by the CrossRef and EZID DOI providers as well, which I think call XmlMetadataTemplate from the AbstractDOIProvider method, which is probably something we want. AI points out that this means that testing would have to be aware of the new parameter, but it isn't hard to make a test that reads a jvmparam (rather than having the XmlMetadataTemplate constructor that takes in the param value in the test now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY27 Sprint 5 FY27 Sprint 5 (2026-08-26 - 2026-09-09) FY27 Sprint 6 FY27 Sprint 6 (2026-09-09 - 2026-09-23) Size: 10 A percentage of a sprint. 7 hours.

Projects

Status: In Review 🔎

Development

Successfully merging this pull request may close these issues.

Suggestion: Limit the size of the datacite.xml generated by Dataverse for datasets with many datafiles (thousands)

5 participants