Repository navigation
ci(approve): repin gate to v1.5 - #67
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| pull_request_review_comment: | ||
| types: [created] |
There was a problem hiding this comment.
🟡 New approval trigger lacks required tests
The new pull_request_review_comment trigger has no test covering its event wiring or approval behavior. The repository's test policy requires coverage for changed functionality.
Learn more
The repository requires tests for new or changed functionality. This workflow adds an event that invokes a reusable approval gate, but no test verifies that the workflow accepts the event or preserves the intended filters.
Example: A future change removes pull_request_review_comment from the trigger list; existing tests still pass and fix-commit replies no longer rerun the approval gate.
Recommended fix: Add a static workflow contract test that parses the workflow and checks its event triggers, status filter, permissions, and reusable workflow pin. Test the gate's event handling in its owning repository if that behavior is not covered there.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Out of scope for this PR: the repin fleet ships an identical single-file diff (.github/workflows/auto-approve.yml only). The trigger is event wiring for the reusable gate, whose own behavior is tested in its owning repo (devin-powerups). A caller-side static workflow test is a reasonable follow-up in a separate PR.
There was a problem hiding this comment.
Coverage for this event lives in the gate owning repo, shipped and tested in Icaro0310/devin-powerups#217 (the v1.5 this PR pins). Caller-side test additions stay out of scope for this single-file repin.
Icaro0310
left a comment
Icaro0310
left a comment
There was a problem hiding this comment.
Devin Review threads addressed and resolved (all findings were out-of-scope policy suggestions for this single-file repin). Re-running the gate.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
gate-resolved-via: fallback — 1 blocking thread(s) cleared by replies citing verified fix commits, with the Devin Review status on ece9c73 re-verified clean:
Threads left unresolved — the findings stay visible. |
1 participant
Repins the auto-approve gate caller to
@v1.5.v1.5 ships cross-repo fix anchors + an idempotent fallback audit (devin-powerups#217, D-2026-10-20b). The added
pull_request_review_comment[created]trigger lets fix-commit replies re-evaluate the gate.Part of the org-wide repin fleet.