Skip to content

fix(cli): align extension management with v2 and clarify contribution requirements - #153

Merged
xiaoland merged 6 commits into
mainfrom
feat/ecosystem-contribution-dx
Oct 26, 2026
Merged

xiaoland merged 6 commits into
mainfrom
feat/ecosystem-contribution-dx

Conversation

@xiaoland

@xiaoland xiaoland commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Intent

The released CLI uses an obsolete extension installation endpoint, which returns 405 against the current Core. Configuration discovery also reads a schema from the shared identity after that field moved to peer status.

Use select --distribution python|module_federation --version VERSION [--peer] and unselect [--peer] with the selection API, retain the DELETE receipt, and expose status for the connected peer. Discover configuration schema from that peer's v2 status. Update CLI and contributor documentation, add an explicit breaking-change fragment, and run three HTTP boundary regressions in the CLI check.

Primary scope: cli. Release project: inkcre-cli.
Tracking issue: InKCre/.github#39.

Evidence

  • pdm run -p cli check: lint, format, type checking, and three unittest cases passed.
  • pdm build -p cli: wheel and sdist built.
  • pdm run python scripts/release.py check --base origin/main passed for the submitted change.
  • A real Core and isolated disposable PostgreSQL exercised wheel download, selection, managed restart, enabling, source creation/collection, status/configuration discovery, disabling, and unselection. Shared configuration and persisted source information survived unselection.
  • HTTP regressions cover both distributions, peer routing, DELETE receipts, and schema discovery. Remote Web peer forwarding was not exercised end to end. Current-head GitHub checks remain authoritative after further changes.

Next action

Merged after maintainer authorization as 15a4cce6c01eee2bb3e5f8654a802a341a304dba. @xiaoland coordinates the remaining release decision in #161, which now prepares CLI 0.3.0 together with Core 0.9.0. The source merge kept the existing CLI version, so its publication job correctly skipped upload. docs#40 is already deployed and retains the temporary source-install path until the corrected CLI is published.

Risk and rollback

The command change is breaking: ambiguous install/uninstall aliases are replaced rather than preserved. The release system consumes the .removed.md fragment. No database migration is included. Reverting before publication restores the old CLI, including its known 405 failure against current Core.

Delivery effects

The mandatory checks and CLI checks passed on final head f188c37; only the public release-note language changed after the previously accepted runtime evidence. Main runtime artifact, deployment, Extension release, and release-preparation workflows passed. No CLI upload, shared-database mutation, or submodule update was performed. The generated cross-project release remains a separate review and delivery step.

Related work

No stacked parent or child PR.
.github#36, docs#40, impl-ts#171, ui#64.

- 区分主要实现 scope 与独立发布项目范围
- 补齐 fork CI、安装依赖和 CLI 验证说明
- 使用 Peer selection API 并保留取消选择回执
- 从当前 Peer 状态发现配置 schema,增加 status 命令
- 添加 HTTP 边界回归测试和破坏性变更片段
@xiaoland xiaoland added bug Something isn't working area/cli labels Oct 26, 2026
@xiaoland xiaoland self-assigned this Oct 26, 2026
@xiaoland xiaoland changed the title fix(cli): 对齐 v2 扩展管理并完善贡献约定 fix(cli): align extension management with v2 and clarify contribution requirements Oct 26, 2026
@xiaoland xiaoland moved this to Review / acceptance in InKCre Current Work Oct 26, 2026
@xiaoland xiaoland removed the area/cli label Oct 26, 2026
- Preserve current main changes before reviewing contribution delivery.
- Keep the new v2 selection and release instructions accessible to community contributors.
@xiaoland
xiaoland marked this pull request as ready for review October 26, 2026 07:11
- Preserve the breaking command and API requirements in the public release note.
@xiaoland
xiaoland merged commit 15a4cce into main Oct 26, 2026
7 of 8 checks passed
@github-project-automation github-project-automation Bot moved this from Review / acceptance to Done in InKCre Current Work Oct 26, 2026

This branch was successfully deployed

1 active deployment
preview — f188c378 Deployed Oct 26, 2026 by xiaoland via impl-py preview cleanup #519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant