feat: add HYGON platform support across runtime, device, build, and launcher stack - #55
Merged
Merged
Conversation
Add explicit returns to small void helper methods used by the MPI examples and communicator setup so DTK hipcc builds stay warning-clean on Hygon. File Changes: - `examples/utils.h` - `src/backends/mpi/ompi/comm_instance.h` - `src/communicator.h`
…clude HYGON as a supported device/platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the HYGON platform, enabling both build-time and runtime integration. Existing examples using the MPI backends (e.g., OpenMPI) can now run on HYGON hardware with platform-specific specializations.
Changes include build logic, device priority handling, runtime specialization, and example execution support.
Changes
Hygon Build Integration
DTKROOT,DTK_ROOT,ROCM_PATH,HIP_PATH, or the default/opt/dtkpath;libamdhip64, andhipcc, then uses DTKhipccas the C++ compiler for Hygon builds.Hygon Runtime Device Support
Device::Type::kHygon, string mappings, and device priority handling insrc/device.h;src/devices/hygon/runtime_.h;src/devices/hygon/device_.h.Hygon Data Type and Casting Support
halfandhip_bfloat16insrc/devices/hygon/data_type_.h;src/devices/hygon/caster_.h;MPI Example Build Cleanup
voidhelpers that DTKhipccwarned about. Touches:src/communicator.hsrc/backends/mpi/ompi/comm_instance.h, andexamples/utils.h.Documentation and Template Updates
.github/pull_request_template.mdto include HYGON as a supported platform;README.mdto include HYGON as a supported platform.Platform and Backend Affected
Platform
Backend
Performance Impact
N/A.
Known Issues & Future Work
AUTO_DETECT_DEVICES=ONwill also detect and enablenvidia, which may cause errors at this point. In this case, it is recommended to disableAUTO_DETECT_DEVICESand manually enable only HYGON.Test Results
Test Involved Platform
Test Involved Backend
HYGON (single node, OpenMPI):
mpi_all_gather.log
mpi_all_reduce.log
mpi_all_to_all.log
mpi_broadcast.log
mpi_gather.log
mpi_reduce.log
mpi_reduce_scatter.log
mpi_scatter.log
mpi_send_recv.log
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).Python Specific (if Python files changed)
Testing
Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety