refactor(ops): migrate softmax to canonical InfiniOps API - #1471
Closed
voltjia wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by #1480, which consolidates the canonical InfiniOps adapter migrations while preserving each logical change as a separate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SoftmaxInfinilmto canonicalSoftmaxAPI alignment
SoftmaxInfinilm::Call(handle, config, input, dim, dtype, out)Softmax::Call(handle, config, input, dim, dtype, out)torch.nn.functional.softmax(input, dim=None, _stacklevel=3, dtype=None). InfiniOps omits Python's internal_stacklevelargument and adds the explicit trailing C++ output tensor.Dependency
This PR is based on
refactor/migrate-paged-caching-infiniops/ #1467 and advances the InfiniOps gitlink frome733e325toeec65a13, the head of InfiniOps #890, which adds canonical CUDA-compatible softmax providers.Against #1467, this PR changes one adapter file and the InfiniOps gitlink.
Validation
Validated commit
86bec726remotely onssh nvidiawithaccelerator-dev/nvidia:latest, using the exact InfiniOps #890 headeec65a13in a temporary integration merge:_infinicorewith the canonicalsoftmaxprovider in the wrapper allowlistinfinicore::op::softmax; output matched a row-wise host referenceclang-format 16.0.6 --dry-run --Werrorpassed for the changed C++ filegit diff --checkpassed