refactor(ops): use canonical InfiniOps softmax API - #1477
Open
voltjia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SoftmaxInfinilmwith the canonical InfiniOpsSoftmaxAPI.Alignment
softmax(input, dim, out)Softmax(input, dim, dtype=nullopt, out)torch.nn.functional.softmax(input, dim, dtype=None), InfiniOpsSoftmax, InfiniOps #890The omitted dtype remains
std::nullopt, matching the existing behavior of preserving the input dtype.Why
InfiniOps now exposes the standard PyTorch-aligned softmax interface and its CUDA provider, so the deprecated InfiniLM compatibility class is no longer needed by this adapter.
Scope
This is stacked on #1476 for the validated InfiniOps pin. It does not change the public InfiniCore softmax API or add overloads.
Screenshots: N/A (backend adapter migration only).
Validation
Run on
ssh nvidiainaccelerator-dev/nvidia:lateston NVIDIA A100 GPUs:infinicore_cpp_apiand_infinicorebuild/install passed.python3 scripts/format.py --ref 850fb3f7 --path src --checkwith clang-format 16.0.6.git diff --check.