fix: copy optional tensor metadata - #881
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tensor::Shapemembers instead of mixing borrowedShapeViewvalues with owning empty shapes.Tensor::Stridesmembers across BinaryCrossEntropy, MultiMarginLoss, and both FlashAttention wrappers.Motivation
InfiniTensor/InfiniRT#38 changed lvalue
TensorView::shape()andstrides()to return borrowed metadata views. Conditional initializers that paired those views with owning empty metadata no longer had a common C++ type, so InfiniOps failed to compile against the current InfiniRTmaster.The smoke-build failure was discovered by #878. A full build found the same compatibility issue in three additional consumers, which this PR fixes together.
Related:
TensorViewmetadata storage InfiniRT#38No issue is closed by this PR.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
The full CPU+NVIDIA+
WITH_TORCHwheel built successfully against the pinned InfiniRT commit. The complete pytest suite ran, but it was not clean: all 50 failures were in unchanged test modules outside the affected operators. The pre-fix baseline cannot reach pytest against this InfiniRT commit because its full build fails on the metadata type errors.Full build and `pytest` output (trimmed)
Benchmark / Performance Impact
N/A. This is a compile-time compatibility fix. The classes already store owning metadata; the patch makes the required view-to-owner copy explicit in conditional expressions.
Notes for Reviewers
ShapeView/StridesViewwith owning empty metadata.