[codex] refactor: consolidate interned Python names - #900
Draft
voltjia wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InternedNamescacheThe cache retains non-owning
py::handlefields, so the intentionally retained interned-name references are not decref'd during static destruction.GetInternedNames()keeps Python C API initialization deferred until a conversion runs with an active interpreter.Validation
git diff --checkclang-format 21.1.8 --dry-run --Werror src/pybind11_utils.hPerformance
Baseline:
af5d19e254ee14f1a8b7b215354104b56d2877ee(#832 current head)Candidate:
40beaed0Both variants were built in fresh virtual environments with the same InfiniRT prefix, CUTLASS checkout, compiler, and focused
abs,add,gemmconfiguration.Raw cross-process timings on the shared host showed a bimodal CPU P-state (the same conversion path alternated between about 1.53 us and 2.17 us), so those unnormalized timings were not used for the final claim. The causal follow-up used an in-process four-call pybind control with ABBA block order:
cuda:0Both confidence intervals are below the +2% regression margin. The validation-only benchmark binding and result files are not part of this commit.