feat(linked): add vLLM topk_sigmoid provider - #909
Merged
Conversation
voltjia
force-pushed
the
feat/linked-topk-sigmoid-provider
branch
from
August 7, 2026 18:08
ac3eff2 to
3487387
Compare
voltjia
force-pushed
the
feat/linked-topk-sigmoid-provider
branch
2 times, most recently
from
August 8, 2026 00:56
e403a09 to
a0650e3
Compare
topk_sigmoid provider
voltjia
force-pushed
the
feat/linked-topk-sigmoid-provider
branch
from
August 8, 2026 02:59
a0650e3 to
952784f
Compare
voltjia
marked this pull request as ready for review
August 8, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_moe_C::topk_sigmoid.Motivation
The installed vLLM provider exposes
topk_sigmoidthrough the C10 Dispatcher.This PR adds a thin linked adapter while retaining the native implementation for
the full InfiniOps contract.
#906 is merged and provides the shared
vllm/_moe_C.*.solibrary mapping.N/A - no linked issue.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvementrefactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_HYGON)WITH_TORCH)Smoke Test Result
Remote environment: A100 with the Verl vLLM 0.20.2 provider image, using an
operator-pruned Release/NDEBUG build with
WITH_LINKED=ON.The smoke allowlist is unchanged.
Test Results on Supported Platforms
40 passed in 1.15s; earlier native+linked regression:46 passedBenchmark / Performance Impact
N/A - no performance claim.
Notes for Reviewers
renormalization, but does not expose InfiniOps'
is_paddingorrouted_scaling_factorarguments.is_padding=Noneandrouted_scaling_factor == 1.0; both capability boundaries useTORCH_CHECK, including Release builds. Native slot 0 remains the defaultand supports the complete API.
adapter validates metadata/capabilities and then returns before stream or
tensor conversion when
um_tokens == 0`; the focused test verifies a
subsequent CUDA operation and synchronization remain clean.
present/absent, renormalization, a non-default stream, empty input, and both
unsupported-argument checks.
tests/test_topk_sigmoid.pyexplicitly select slot 16.Builds without the provider skip only those cases after checking the active
implementation list; the native cases remain in the same module.