cleanup: remove headscale - #19
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the previously implemented headscale/SandD access channel integration and all associated AWS bootstrap, manager wiring, Kubernetes manifests/samples, and documentation, leaving the codebase without the headscale/keybroker-based tunnel mechanism.
Changes:
- Removes SandD key-minting client code, headscale keybroker service, and related tests.
- Simplifies AWS provider bootstrap/user-data generation and provider constructors by deleting SandD-specific logic/parameters.
- Deletes the
config/sanddoverlay + samples and removes deploy-time substitution logic and third-party notice references tied to that integration.
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| THIRD_PARTY_NOTICES.md | Removes Tailscale-related third-party notice that was specific to the SandD channel. |
| README.md | Removes reference to third-party notices file from the License section. |
| pkg/sandd/keybroker.go | Deletes the broker client used for key minting. |
| pkg/sandd/keybroker_test.go | Deletes tests for the broker client. |
| pkg/provider/provider.go | Removes SandD-related provider-agnostic types/interfaces. |
| pkg/provider/aws/translate.go | Removes SandD bootstrap injection and related constants/shim logic; keeps plain docker-run mapping. |
| pkg/provider/aws/sandd_test.go | Deletes AWS provider tests covering SandD key minting and injection behavior. |
| pkg/provider/aws/client.go | Removes SandD config parameter from AWS provider construction. |
| pkg/provider/aws/client_test.go | Removes SandD-enabled bootstrap tests; keeps/renames plain bootstrap test. |
| pkg/provider/aws/aws.go | Removes SandD fields/state and per-instance SandD resolution logic from the AWS provider. |
| Makefile | Removes keybroker image build/push targets and deploy-time substitution flow. |
| hack/deploy.sh | Removes SANDD_TUNNEL_SERVER plumbing passed into make deploy. |
| Dockerfile.keybroker | Deletes the keybroker container image definition. |
| config/sandd/README.md | Deletes SandD overlay documentation. |
| config/sandd/manager-config.yaml | Deletes SandD manager ConfigMap overlay. |
| config/sandd/kustomization.yaml | Deletes SandD overlay kustomization. |
| config/sandd/headscale.yaml | Deletes headscale + keybroker sidecar deployment manifests. |
| config/samples/sandd-controller.yaml | Deletes the SandD controller sample manifest. |
| config/samples/headscale-service.yaml | Deletes the headscale LoadBalancer Service sample manifest. |
| config/manager/manager.yaml | Removes required envFrom ConfigMap reference for SandD wiring. |
| config/default/kustomization.yaml | Removes ../sandd overlay inclusion and updates patch scoping comments. |
| cmd/main.go | Removes SandD wiring/env usage and updates AWS provider registration call signature. |
| cmd/keybroker/main.go | Deletes the keybroker HTTP service implementation. |
| cmd/keybroker/main_test.go | Deletes keybroker tests. |
| .env.example | Removes SandD endpoint documentation/variable from the example env file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/lgtm |
InftyAI-Agent
approved these changes
Aug 5, 2026
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?