Skip to content

cleanup: remove headscale - #19

Merged
InftyAI-Agent merged 2 commits into
InftyAI:mainfrom
kerthcet:feat/dialout-jwt
Aug 5, 2026
Merged

cleanup: remove headscale#19
InftyAI-Agent merged 2 commits into
InftyAI:mainfrom
kerthcet:feat/dialout-jwt

Conversation

@kerthcet

@kerthcet kerthcet commented Aug 5, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?


Signed-off-by: kerthcet <kerthcet@gmail.com>
Copilot AI lite review requested due to automatic review settings August 5, 2026 15:27
@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the previously implemented headscale/SandD access channel integration and all associated AWS bootstrap, manager wiring, Kubernetes manifests/samples, and documentation, leaving the codebase without the headscale/keybroker-based tunnel mechanism.

Changes:

  • Removes SandD key-minting client code, headscale keybroker service, and related tests.
  • Simplifies AWS provider bootstrap/user-data generation and provider constructors by deleting SandD-specific logic/parameters.
  • Deletes the config/sandd overlay + samples and removes deploy-time substitution logic and third-party notice references tied to that integration.

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
THIRD_PARTY_NOTICES.md Removes Tailscale-related third-party notice that was specific to the SandD channel.
README.md Removes reference to third-party notices file from the License section.
pkg/sandd/keybroker.go Deletes the broker client used for key minting.
pkg/sandd/keybroker_test.go Deletes tests for the broker client.
pkg/provider/provider.go Removes SandD-related provider-agnostic types/interfaces.
pkg/provider/aws/translate.go Removes SandD bootstrap injection and related constants/shim logic; keeps plain docker-run mapping.
pkg/provider/aws/sandd_test.go Deletes AWS provider tests covering SandD key minting and injection behavior.
pkg/provider/aws/client.go Removes SandD config parameter from AWS provider construction.
pkg/provider/aws/client_test.go Removes SandD-enabled bootstrap tests; keeps/renames plain bootstrap test.
pkg/provider/aws/aws.go Removes SandD fields/state and per-instance SandD resolution logic from the AWS provider.
Makefile Removes keybroker image build/push targets and deploy-time substitution flow.
hack/deploy.sh Removes SANDD_TUNNEL_SERVER plumbing passed into make deploy.
Dockerfile.keybroker Deletes the keybroker container image definition.
config/sandd/README.md Deletes SandD overlay documentation.
config/sandd/manager-config.yaml Deletes SandD manager ConfigMap overlay.
config/sandd/kustomization.yaml Deletes SandD overlay kustomization.
config/sandd/headscale.yaml Deletes headscale + keybroker sidecar deployment manifests.
config/samples/sandd-controller.yaml Deletes the SandD controller sample manifest.
config/samples/headscale-service.yaml Deletes the headscale LoadBalancer Service sample manifest.
config/manager/manager.yaml Removes required envFrom ConfigMap reference for SandD wiring.
config/default/kustomization.yaml Removes ../sandd overlay inclusion and updates patch scoping comments.
cmd/main.go Removes SandD wiring/env usage and updates AWS provider registration call signature.
cmd/keybroker/main.go Deletes the keybroker HTTP service implementation.
cmd/keybroker/main_test.go Deletes keybroker tests.
.env.example Removes SandD endpoint documentation/variable from the example env file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: kerthcet <kerthcet@gmail.com>
Copilot AI review requested due to automatic review settings August 5, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 26 changed files in this pull request and generated no new comments.

@kerthcet

kerthcet commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

/lgtm
/kind cleanup

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Aug 5, 2026

@InftyAI-Agent InftyAI-Agent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: PR has both lgtm and approved labels

@InftyAI-Agent
InftyAI-Agent merged commit 2cae49c into InftyAI:main Aug 5, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants