feat(mini-player): the show canvas toggle, like the now playing panel - #725
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: InstaZDLL/WaveFlow/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughLe mini-lecteur ajoute un bouton Canvas dans sa barre supérieure. Le bouton apparaît lorsque Canvas est disponible et que la réduction des mouvements est désactivée. La documentation décrit ce comportement. ChangesContrôle Canvas du mini-lecteur
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
The mini-player plays the Canvas since #724 but had no way to hide it: the Show Canvas toggle only existed in the immersive view and the Now Playing panel.
CanvasToggleButton, in the mini-player's top bar, shown under the same condition (the track has a clip, motion is not reduced), so it is never a dead control.storagelistener feat: finer spectrum, estimated karaoke, clips in the mini-player, artists to split #724 added touseCanvasEnabled.ui.mdlists the third surface.Checks:
bun run typecheck, eslint, prettier, local review clean. Frontend only — nothing on the Rust side.Summary by CodeRabbit