Skip to content

feat(mini-player): the show canvas toggle, like the now playing panel - #725

Merged
InstaZDLL merged 1 commit into
mainfrom
feat/mini-canvas-toggle
Sep 21, 2026
Merged

InstaZDLL merged 1 commit into
mainfrom
feat/mini-canvas-toggle

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Sep 21, 2026 •

Copy link
Copy Markdown
Owner

The mini-player plays the Canvas since #724 but had no way to hide it: the Show Canvas toggle only existed in the immersive view and the Now Playing panel.

Checks: bun run typecheck, eslint, prettier, local review clean. Frontend only — nothing on the Rust side.

Summary by CodeRabbit

  • Nouvelles fonctionnalités
    • Ajout du bouton « Afficher le Canvas » dans la barre supérieure du mini-lecteur.
    • Le bouton permet d’activer ou de désactiver l’affichage Canvas lorsque celui-ci est disponible.
    • L’état visuel du bouton reflète la préférence Canvas partagée avec les autres vues.
    • Les priorités d’affichage restent cohérentes : Canvas, animation de couverture, diaporama, puis couverture fixe.
    • Le comportement respecte les restrictions liées au réglage Canvas et à la préférence de réduction des mouvements.

@InstaZDLL InstaZDLL added scope: frontend React/Vite frontend (src/) scope: docs Docs, README, assets type: feat New feature size: s 10-50 lines labels Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: InstaZDLL/WaveFlow/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8841c45b-9a4b-4656-a2d3-2a9726b976e1

📥 Commits

Reviewing files that changed from the base of the PR and between 7c47521 and 4c1ff70.

📒 Files selected for processing (2)
  • docs/features/ui.md
  • src/components/views/MiniPlayer.tsx

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


📝 Walkthrough

Walkthrough

Le mini-lecteur ajoute un bouton Canvas dans sa barre supérieure. Le bouton apparaît lorsque Canvas est disponible et que la réduction des mouvements est désactivée. La documentation décrit ce comportement.

Changes

Contrôle Canvas du mini-lecteur

Layer / File(s) Summary
Ajout du contrôle Canvas
src/components/views/MiniPlayer.tsx, docs/features/ui.md
MiniPlayer utilise CanvasToggleButton et setCanvasEnabled. Le bouton inverse canvasEnabled et indique son état actif. La documentation précise ses conditions d’affichage et ses garde-fous.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Le titre décrit clairement l’ajout du bouton Show Canvas au mini-player. Il suit aussi le format Conventional Commits avec le scope kebab-case « mini-player ».
Description check ✅ Passed La description résume le changement, précise les conditions d’affichage, le partage de préférence et les validations effectuées. Elle ne reprend pas les sections explicites « How I tested », « Screens…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@InstaZDLL InstaZDLL self-assigned this Sep 21, 2026
@InstaZDLL
InstaZDLL merged commit 32d6c07 into main Sep 21, 2026
16 checks passed
@InstaZDLL
InstaZDLL deleted the feat/mini-canvas-toggle branch September 21, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: docs Docs, README, assets scope: frontend React/Vite frontend (src/) size: s 10-50 lines type: feat New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant