Skip to content

fix(webapp): point the end-to-end mock at the renamed genre route - #182

Merged
InstaZDLL merged 1 commit into
mainfrom
fix/point-the-e2e-mock-at-the-renamed-route
Sep 10, 2026
Merged

InstaZDLL merged 1 commit into
mainfrom
fix/point-the-e2e-mock-at-the-renamed-route

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Sep 10, 2026

Copy link
Copy Markdown
Owner

CI (Web) is failing on main at 4fc7410, and this is the two-line fix.

#181 moved the route to /api/v2/songs/by-genre and moved the client with it. The end-to-end mock still answered /api/v2/songs, so the genre page loaded nothing and its accessibility sweep never reached a page.

Mine, and avoidable

I checked that rename with cargo fmt, clippy -D warnings, 162 Rust tests, biome, tsc and the web build — and not with test:e2e, which is the one gate that exercises the client against the paths it actually calls. The Rust suite caught its own stale reference to the old path; nothing else was watching the browser's.

Extracted on its own branch so main goes green without waiting for the larger branch this was found on.

Verification

34 Playwright tests pass on this change against main, including the three WCAG A/AA sweeps.

Summary by CodeRabbit

  • Tests
    • Mise à jour des tests de navigation par genre pour utiliser le point d’accès dédié aux chansons par genre.
    • Conservation des vérifications du filtrage des résultats et du paramètre de genre.

`CI (Web)` has been failing on `main` since #181. The route moved to
`/api/v2/songs/by-genre` and the client with it, but the end-to-end
mock still answered the old path, so the genre page loaded nothing and
its accessibility sweep never reached a page.

Mine, and avoidable. The rename was checked with `cargo fmt`, `clippy`,
162 Rust tests, biome, `tsc` and the web build — and not with
`test:e2e`, which is the one gate that exercises the client against the
paths it calls. The Rust suite caught its own stale reference; nothing
else was watching the browser's.

Extracted on its own so `main` goes green without waiting for the
larger branch it was found on.

Claude-Session: https://claude.ai/code/session_01TyKunaKXS16hyFDBHwc5KK
Signed-off-by: InstaZDLL <github.105mh@8shield.net>
@github-actions github-actions Bot added scope: web Embedded web player (React) type: fix Bug fix labels Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ea199adf-bb1e-4180-8dca-8b8ea8cbd840

📥 Commits

Reviewing files that changed from the base of the PR and between 4fc7410 and 064e49f.

📒 Files selected for processing (1)
  • webapp/e2e/studio-nocturne.spec.ts

Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

Le test E2E de navigation par genre utilise désormais /api/v2/songs/by-genre pour le mock et la validation des requêtes. Le filtrage par genre reste inchangé.

Changes

Navigation par genre

Layer / File(s) Summary
Alignement du mock et des assertions
webapp/e2e/studio-nocturne.spec.ts
Le mock API et le test de navigation ciblent /api/v2/songs/by-genre. Le paramètre genre et le filtrage de la réponse restent inchangés.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 064e4

The genre-navigation E2E coverage now matches the renamed API route, restoring the mocked data flow and accessibility checks. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed Le titre décrit précisément la correction principale : le mock end-to-end utilise la nouvelle route de filtrage par genre.
Description check ✅ Passed La description explique la cause, la correction, l’impact utilisateur et la validation effectuée avec 34 tests Playwright. Elle ne reprend pas tous les en-têtes du modèle ni l’attestation DCO, mais el…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/point-the-e2e-mock-at-the-renamed-route

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size: xs < 10 lines type: fix Bug fix and removed type: fix Bug fix labels Sep 10, 2026
@InstaZDLL
InstaZDLL merged commit e947068 into main Sep 10, 2026
13 checks passed
@InstaZDLL
InstaZDLL deleted the fix/point-the-e2e-mock-at-the-renamed-route branch September 10, 2026 13:04
InstaZDLL added a commit that referenced this pull request Sep 15, 2026
@github-actions github-actions Bot added type: fix Bug fix and removed type: fix Bug fix labels Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: web Embedded web player (React) size: xs < 10 lines type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant