fix(webapp): point the end-to-end mock at the renamed genre route - #182
Conversation
`CI (Web)` has been failing on `main` since #181. The route moved to `/api/v2/songs/by-genre` and the client with it, but the end-to-end mock still answered the old path, so the genre page loaded nothing and its accessibility sweep never reached a page. Mine, and avoidable. The rename was checked with `cargo fmt`, `clippy`, 162 Rust tests, biome, `tsc` and the web build — and not with `test:e2e`, which is the one gate that exercises the client against the paths it calls. The Rust suite caught its own stale reference; nothing else was watching the browser's. Extracted on its own so `main` goes green without waiting for the larger branch it was found on. Claude-Session: https://claude.ai/code/session_01TyKunaKXS16hyFDBHwc5KK Signed-off-by: InstaZDLL <github.105mh@8shield.net>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughLe test E2E de navigation par genre utilise désormais ChangesNavigation par genre
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The genre-navigation E2E coverage now matches the renamed API route, restoring the mocked data flow and accessibility checks. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
CI (Web)is failing onmainat4fc7410, and this is the two-line fix.#181 moved the route to
/api/v2/songs/by-genreand moved the client with it. The end-to-end mock still answered/api/v2/songs, so the genre page loaded nothing and its accessibility sweep never reached a page.Mine, and avoidable
I checked that rename with
cargo fmt,clippy -D warnings, 162 Rust tests, biome,tscand the web build — and not withtest:e2e, which is the one gate that exercises the client against the paths it actually calls. The Rust suite caught its own stale reference to the old path; nothing else was watching the browser's.Extracted on its own branch so
maingoes green without waiting for the larger branch this was found on.Verification
34 Playwright tests pass on this change against
main, including the three WCAG A/AA sweeps.Summary by CodeRabbit