Remove deprecated biome-related classes and methods. - #3629
Open
MattBDev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes deprecated biome-related classes and methods. Code that previously relied on these now uses direct biome type lookups.
BiomeData,BiomeName, andBiomes(world.biomepackage) — all were@Deprecatedfor removal, withBiomes.findBiomeByNamerelying on outdated Levenshtein-distance fuzzy name matching instead of exact registry IDs.Files Changes
BiomeData,BiomeName, andBiomesall were@Deprecatedand removedgetData(BiomeType)method fromBiomeRegistrygetDataoverrides fromBukkitBiomeRegistryandNullBiomeRegistryPlotSetBiomefromBiomes.findBiomeByName(...)toBiomeTypes.get(args[0].toLowerCase(Locale.ROOT))Behavior change
The command
/plot setbiome <name>for PlotSquared accepted misspelled/fuzzy names before this change. Fuzzy name matching was just catching single-character typos. The new behavior is now more consistent WorldEdit's/setbiomecommand which never did fuzzy matching. The tab-completion already steers users to the valid biome IDs, so users will typically never type out the entire biome name themselves. In theory, this change should be virtually invisible to the user.I would consider adding the fuzzy matching back to the command out of scope for this PR since this behavior should have been consistent across all commands in the first place.