[repo-assist] test: Add unit tests for BookToolQueryService - #1404
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Adds coverage for the MCP book-tool query service, which previously had no direct unit tests despite backing several MCP tools (GetChapterList, GetChapterSections, GetDirectContentUrl, GetNavigationContext, GetChapterSummary). Tests cover: - Successful chapter listing / section lookups with ordering - McpException thrown for unknown chapters and blank/unknown section keys - Navigation context previous/next/parent resolution - Guideline filtering by chapter number in chapter summaries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/repo-assist make sure the tests are DRY and using latest and best TUnit syntax and we should be using ! unecessarily like we are now |
Contributor
Author
|
Repo Assist is processing issue comment, see workflow run... |
23 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
BookToolQueryServicebacks several MCP tools used by the AI chat integration (GetChapterList,GetChapterSections,GetDirectContentUrl,GetNavigationContext,GetChapterSummary) but had no direct unit test coverage. This PR adds a focused test suite covering the service's public API.Changes
EssentialCSharp.Web.Tests/BookToolQueryServiceTests.cswith 12 tests usingMoq(matching the existing repo convention for services with mockable dependencies), covering:GetChapterListMcpExceptionon unknown chapter inGetChapterSectionsGetDirectContentUrlGetNavigationContextGetChapterSummaryNo production code was changed.
Test Status
dotnet build EssentialCSharp.Web.Tests --configuration Release— ✅ succeeded, 0 warnings/errorsdotnet test EssentialCSharp.Web.Tests --configuration Release --no-build— 159/161 passed. The 2 pre-existing failures (CaptchaService_Verify_Success,KnownBreachedPassword_IsDetected) are unrelated integration tests that call external network services (hCaptcha, HaveIBeenPwned) unreachable from this sandboxed environment; they fail identically onmainwithout this change.dotnet format EssentialCSharp.Web.Tests --verify-no-changes— no issues reported for the new file (pre-existing formatting/naming findings in other files are unrelated to this change).This is an automated contribution from Repo Assist. Please review before merging.
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
api.hcaptcha.comapi.pwnedpasswords.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.
Add this agentic workflow to your repo
To install this agentic workflow, run