fix: stop sending OPENAI_ORG_ID / OPENAI_PROJECT_ID to Interfaze - #23
Open
Abhishek-B-R wants to merge 1 commit into
Open
Abhishek-B-R wants to merge 1 commit into
Abhishek-B-R wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the openai client reads OPENAI_ORG_ID and OPENAI_PROJECT_ID from the environment and puts them on every request as OpenAI-Organization / OpenAI-Project. since Interfaze() is built on that client, anyone who also has openai configured on their machine sends their openai org and project ids to api.interfaze.ai.
repro: set OPENAI_ORG_ID=org-secret, call Interfaze(api_key=...).chat.completions.create(...), and the request carries
openai-organization: org-secret.this resets both to whatever was passed explicitly after the client is built, for sync and async. passing organization= / project= yourself still works.
tests: one that sets both env vars and checks neither header goes out (sync + async, fails on main), and one that checks explicit values still go through. pytest (140 passed, coverage gate ok), ruff and mypy --strict all pass.
same fix for the js SDK is in InterfazeAI/interfaze-js#17. OPENAI_CUSTOM_HEADERS gets merged in the same way here and can carry things like a gateway key; left it out to keep this small, happy to add it if you want it handled.