Make VideoDecoder Support Videos with Alpha - #7
Open
menvae wants to merge 1 commit into
Open
Conversation
menvae
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't support all formats with alpha, it only supports formats with YUVA (and other pixel formats with alpha) such as mov (codec must be ProRes 4444 or QuickTime) and webm (VP8 and VP9). (webm isn't YUVA but you get the point).
Since the ffmpeg build of the framework doesn't include the necessary build flags to do this natively we have to do some fuckery by manually getting the side data (BlockAdditional), which is not really necessary for mov but it is needed for webm.
Side Note: mov codecs with transparency do not work cuz the framework build of ffmpeg does not have the decoders for ProRes and QuickTime. I only mentioned it cuz it should work if it is ever added to the framework. Only webm works for transparency as of now.