fix(radio): recalibrate noise floor after AGC reset - #15
Merged
IoTThinks merged 2 commits intoAug 18, 2026
Merged
Conversation
IoTThinks
reviewed
Aug 18, 2026
| // Recalibrate synchronously so callers never observe the temporary zero | ||
| // used to bypass a stale sampling threshold after an AGC reset. | ||
| const int16_t previous_noise_floor = _noise_floor; | ||
| _noise_floor = 0; |
Owner
There was a problem hiding this comment.
This is the culpit.
Even with this PR, there will be a very slim chance to see noisefloor 0.
IMO, I will experiment a different default noise floor if someone still sess noise floor 0.
Owner
|
I have merged it and will test on my test kits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recalculates the noise floor immediately after an AGC reset, preventing temporary zero readings. Sampling preserves active packet reception and never restarts RX while a packet is in progress.