Repository navigation
feat: add net10.0 target framework to com.IvanMurzak.CodeExec - #17
Merged
Merged
Conversation
CodeExec Core: netstandard2.0;net8.0 -> + net10.0 (collectible AssemblyLoadContext host, same as net8.0). The package gains lib/net10.0 and an empty net10.0 dependency group; netstandard2.0 and net8.0 are unchanged. CodeExec.Roslyn (source-only) and the samples are untouched. CI already installs 10.0.x and the tests already run on net8.0 and net10.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…work wording Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… lib/net10.0 is exercised Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
net10.0to Code-Exec Core (dotnet/CodeExec/CodeExec.csproj:netstandard2.0;net8.0→+net10.0). On net10.0 Core takes the sameNET8_0_OR_GREATERcollectibleAssemblyLoadContexthost as net8.0.netstandard2.0(Unity/Mono, .NET Framework) is unchanged, and so is the vendored source: no.csfile changed, and Core stays C# 9 and dependency-free.CodeExec.Roslynand SourceConsumer are untouched. No version bump, no release.samples/PackageConsumernow targetsnet8.0;net10.0, andscripts/consume.shruns it per TFM, so CI's package job and the release gate exercise the packedlib/net10.0too. Verified locally: the assets file resolveslib/net10.0/com.IvanMurzak.CodeExec.dllfor net10.0 andlib/net8.0/…for net8.0.8.0.x+10.0.xand already tests on net8.0 and net10.0. No workflow change.Pack evidence (
scripts/pack.sh, origin/main vs this branch, version 0.4.1)com.IvanMurzak.CodeExecfile list diff:nuspec diff:
lib/netstandard2.0/*andlib/net8.0/*(dll + xml) are byte-identical (cmp). The existing dependency groups are unchanged (empty).com.IvanMurzak.CodeExec.Roslyn: file list, nuspec and allsrc/andbuild/files are identical.Tests (local)
CodeExec.Tests: 332/332 on net8.0 and on net10.0, with Roslyn 4.8.0 and 3.8.0.scripts/consume.sh 3.8.0 5.9.0: all four runs (2 Roslyn × 2 TFMs) succeed.Note for the train (outside this repo)
A code-exec train makes the Godot-MCP chain legs self-pack
CodeExec.csproj. Theirsetup-dotnetsteps install only8.0.x/9.0.x. That works only if the hostedubuntu-latestimage already ships SDK 10; otherwise the pack fails with NETSDK1045. Worth adding10.0.xthere before the next train. The same applies to ReflectorNet's net10 change.Quality stages
/simplify: comment and README wording (simplify:commit).code review:commit).🤖 Generated with Claude Code