Fix emulator covariance batching and group cache collisions - #8
Draft
botjean wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emulator.pklfilename for a single unnamed group.Root causes
predict()divided an already normalized PCA residual covariance by the number of parameter points in the current prediction call. The same physical point therefore received different emulator covariance when evaluated alone versus in a batch.Separately, all emulator groups defaulted to
emulator.pkl, so multi-emulator configurations could silently overwrite one group with another. This change uses group names only when more than one group is configured, retaining single-group cache compatibility.Validation
6 passed22 passed31 passedgit diff --check: clean