Removing generation of matrices which can't be modeled - #30
Merged
Conversation
Update createMLinputList() to accomodate cross drug testing.
AbhirupaGhosh
approved these changes
Aug 6, 2026
AbhirupaGhosh
left a comment
Contributor
There was a problem hiding this comment.
The scripts ran without any error. I made some minor changes I observed in downstream functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes were made to
generate_matrices_ml.Rcode. The motivation is the number of matrices that are created but did not have enough of the minority class, enough genomes, etc. This PR stops the attempt to model these..skipUnusableMatrix(), called from.parquet2LOOMatrix,.parquet2LOODrugMatrixand.parquet2CrossDrugTestMatrix. These matrices are built by removing genomes, so they can end up tiny or single-class. There is no point modeling those, so they're now skipped with a logged reason instead of written.skipImbalancedMatrixwas running beforehand and counting genomes that would never make it in. The check now sees the genomes that survive the join.