Repository navigation
Fix three small defects in the icon, summary, package-test and diff scripts - #44
Merged
Merged
Conversation
New-VIIcon.ps1 and New-SummaryImage.ps1 handed -OutFile straight to Bitmap.Save. .NET resolves a relative path against the process working directory, which is not the PowerShell location after Set-Location, so the picture could land in another folder than the one named. Both scripts now resolve -OutFile against the PowerShell location first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- When the installed example did not answer, Test-McpServer.ps1 exits with 99 and the summary said "99 required checks failed". It now says the example did not answer at the URL. - A -LabVIEWPath that does not exist threw from Resolve-Path. It now stops with "::error::<path> does not exist." like the other checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Run by hand without -LabVIEWPath, New-ViDiffReport.ps1 compared in LabVIEW 2020 on port 3365. The working agreement says to compare in the 32-bit LabVIEW 2026 on port 3363, where nobody develops and no other checkout's MCP Server.lvlib is loaded. The defaults now say so. The workflow passes both values explicitly and is unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tests✅ All 64 tests passed. Per-test results
Protocol tests✅ Protocol tester output (0 failed required checks)VI diff reportNo VI, VIM or CTL files changed in this pull request. Report for commit bbf507f. The installable test package is under Artifacts of this run once the build job has finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small defects in the helper scripts, found in a release-readiness pass. A relative
-OutFilecould put pictures in the wrong folder, the installed-package test misreported two early failures, and the VI diff defaulted to a LabVIEW the working agreement says not to compare in.New-VIIcon.ps1 -OutFile rel\icon.pngafterSet-LocationTest-InstalledPackage.ps1 -LabVIEWPathmissing fileResolve-Path::error::<path> does not exist., exit 1New-ViDiffReport.ps1without-LabVIEWPathChanges
tools/icons/New-VIIcon.ps1,tools/ci/New-SummaryImage.ps1(modified): resolve-OutFileagainst the PowerShell location beforeBitmap.Save.tools/ci/Test-InstalledPackage.ps1(modified): checks that-LabVIEWPathexists, and reports exit code 99 ofTest-McpServer.ps1as "did not answer".tools/ci/New-ViDiffReport.ps1(modified): new defaults for-LabVIEWPathand-PortNumber. The workflow passes both explicitly, so CI is unaffected.Verified
New-VIIcon.ps1 -OutFile rel\icon.pngrun from another PowerShell location: the picture is written under that location.Test-InstalledPackage.ps1 -LabVIEWPath C:\nope\LabVIEW.exe -ContentsOnly: prints::error::C:\nope\LabVIEW.exe does not exist.and exits 1.Not verified
ifon the exit code.New-SummaryImage.ps1andNew-ViDiffReport.ps1were not run; only parsed.Known rough edges
None.
🤖 Generated with Claude Code