Repository navigation
Keep the SSE response override names in the package and test every installed example - #50
Merged
Merged
Conversation
The build puts the jg_mcp_ prefix in front of every VI name. A class method only overrides its ancestor's method of the same name, so the renamed Next Segment, Stream Length and Abort Stream of MCP SSE Response no longer overrode IG's Streamable Response. In the installed toolkit the class was broken, and with it Start.vi and every example: none of them could run. The repository was not affected, since it has no prefix. The three VIs now get an empty Namespace override in the .vipb, as the overrides of MCP Handler already had. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test-InstalledPackage.ps1 started only the installed Datalogger example, and CI does not run it yet, so a package whose toolkit classes were broken passed every check. - The contents check now fails on every class override the build renamed. It reads each class's ancestors (from the test LabVIEW's vi.lib for other packages) and compares the method names. Against the 3.0.0.58 test package it reports the three SSE response overrides. - The install test starts the Datalogger, Full Featured and Simple examples in turn and runs the protocol tester against each, closing the test LabVIEW in between. - The pull request template gives the step 45 minutes for three examples. The release template runs the contents check before a package is uploaded or released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tests✅ All 64 tests passed. Per-test results
Protocol tests✅ Protocol tester output (0 failed required checks)VI diff reportNo VI, VIM or CTL files changed in this pull request. Report for commit 24ce15e. The installable test package is under Artifacts of this run once the build job has finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the installed toolkit (test package 3.0.0.58) no example can run:
MCP SSE Response.lvclassis broken, and with itStart.vi. The package build putsjg_mcp_in front of every VI name, and a renamed override no longer overrides its ancestor's method. The repository itself was fine, which is why every test passed. The build spec now keeps the three override names, and the installed-package test now catches this and starts every example.Next Segment.vi,Stream Length.vi,Abort Stream.viin the packagejg_mcp_...: no longer override IG's Streamable Response, class brokenMCP Handleroverrides already hadStart.vi)Test-InstalledPackage.ps1Changes
src/LabVIEW MCP Server SDK.vipb: an empty Namespace override forMCP SSE Response/Abort Stream.vi,Next Segment.viandStream Length.vi.tools/ci/Test-InstalledPackage.ps1:tools/ci/pull-request.workflow.yml(template): the description of the installed-package step is updated; its timeout goes from 30 to 45 minutes.tools/ci/release.workflow.yml(template): a new step, "Check Package Contents" (-ContentsOnly), runs after the build and before the upload or release.tools/ci/README.md: the script's row is updated.No VI changes, so there is no Code summary.
Verified
Full Featured MCP Server\main.viis broken. The Error List gives the root cause as Dependency is broken: jg_mcp_MCP Server.lvlib:jg_mcp_MCP SSE Response.lvclass, viajg_mcp_Start.vi. The same example from the repository is executable.Test-InstalledPackage.ps1 -ContentsOnlyagainst the 3.0.0.58 package fails, as it should, with exactly the three renamed overrides. TheMCP Handleroverrides pass.Not verified
Maintainer steps
tools/ci/pull-request.workflow.ymlandtools/ci/release.workflow.ymlover the live workflows. The live PR workflow doesn't runTest-InstalledPackage.ps1at all yet, which is how this package got out.🤖 Generated with Claude Code