Repository navigation
Conversation
Hand-tidied block diagram layout of 18 VIs: Add Prompt, Add Resource (File), Add Tool, Ask User, Cancel Requested, Get ID from JSON, Get Server Name from ID, MCP Handler's Do Request, Negotiate Protocol Version, Report Progress, Start, Stop, initialize, prompts get, prompts list, resources list, resources read and tool list. LabVIEW's comparison finds only cosmetic changes in all of them; behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Layout of tool call.vi tidied by hand. Reinitialize VI Inputs now takes the error of Check Tool Arguments and passes its own error on to Call VI, so the tool VI's inputs are only reset when the call goes ahead, and an error while resetting them reaches the caller instead of being dropped. The response chain after the call (Finish Tool Call Response, Mark Tool Error Result, Add Structured Content, Check Tool Arguments) stays without error wires on purpose: a call with missing arguments carries an error there, and these VIs must still run to turn it into a result with isError true. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tests✅ All 64 tests passed. Per-test results
Protocol tests✅ Protocol tester output (0 failed required checks)VI changesVIs: 19 modified, 0 added, 0 deleted 13 more modified VIsReport for commit 99289d9. The installable test package is under Artifacts of this run once the build job has finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



















Summary
Hand-tidied block diagram layout of the public API, RPC method and handler VIs. One functional change in
tool call.vi: Reinitialize VI Inputs now sits on the error wire, so a tool VI's inputs are reset only when the call goes ahead, and an error while resetting them reaches the caller instead of being dropped.Changes
Layout only (behaviour unchanged, LabVIEW's comparison finds only cosmetic changes), modified:
Add Prompt.vi,Add Resource (File).vi,Add Tool.vi,Ask User.vi,Cancel Requested.vi,Get ID from JSON.vi,Get Server Name from ID.vi,MCP Handler/Do Request.vi,Negotiate Protocol Version.vi,Report Progress.vi,Start.vi,Stop.vi,initialize.vi,prompts get.vi,prompts list.vi,resources list.vi,resources read.vi,tool list.vi.tool call.vi, modified: layout tidied. Reinitialize VI Inputs takes the error of Check Tool Arguments and passes its own error on to Call VI. The response chain after the call (Finish Tool Call Response, Mark Tool Error Result, Add Structured Content, Check Tool Arguments) stays without error wires on purpose: a call with missing arguments carries an error there, and these VIs must still run to turn it into a result withisError: true.Code summary
To follow once the VI diff report has been posted by the Pull Request Review workflow (pictures in
pr-assets/pr-<number>-summary).Verified
main(0 commits behind).Not verified
tool call.vichange affects).Known rough edges
🤖 Generated with Claude Code