-
Notifications
You must be signed in to change notification settings - Fork 0
chore: retire the legacy CI review pipeline #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,16 @@ jobs: | |
| timeout-minutes: 5 | ||
| env: | ||
| COMMITLINT_PACKAGE_VERSION: "1.0.3" | ||
| # npm's fetch-timeout defaults to 300s — exactly this job's cap — so one | ||
| # stalled request eats the whole budget in silence and the job is killed | ||
| # before npm's own retry ever fires. Observed as five consecutive 5m00s | ||
| # timeouts across align and cluster while the same install took 6s when | ||
| # it worked. Bounding the request keeps the retries useful and turns the | ||
|
Comment on lines
+19
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This six-line incident narrative violates the repository's explicit one-short-line limit for comments. Reduce it to the durable reason the settings exist, such as keeping retries within the job timeout, rather than preserving historical timing details in the workflow. AGENTS.md reference: AGENTS.md:L87-L87 Useful? React with 👍 / 👎. |
||
| # tail from minutes into seconds; the cap below then means what it says. | ||
| npm_config_fetch_timeout: "30000" | ||
| npm_config_fetch_retries: "3" | ||
| npm_config_fetch_retry_mintimeout: "1000" | ||
| npm_config_fetch_retry_maxtimeout: "10000" | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
|
|
@@ -24,7 +34,8 @@ jobs: | |
| - name: Setup Node.js | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: "24" | ||
| # Deliberately policy-pinned: this workflow runs only a version-pinned npm package and takes no toolchain input from the PR tree — the template, not node-version-file, supplies the fleet baseline. | ||
| node-version: "26.5.0" | ||
|
|
||
| - name: Cache conventional-commit-msg download | ||
| uses: actions/cache@v5 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,16 @@ on: | |
| paths: | ||
| - pnpm-lock.yaml | ||
|
|
||
| # pnpm 11 defaults verify-deps-before-run to "install": the first `pnpm | ||
| # <script>` or `pnpm exec` whose deps-status check sees drift re-runs a full | ||
| # install with lifecycle scripts enabled, silently dropping this workflow's | ||
| # install flags — a prepare hook the hardened --ignore-scripts install skipped | ||
| # then runs in CI. Only this spelling disables it: pnpm reads | ||
|
Comment on lines
+14
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This newly introduced multi-line block also conflicts with the repository rule requiring comments to be a single short line. Preserve only the underlying safety constraint—that automatic dependency verification must not reinstall without the hardened flags—and remove the extended operational description. AGENTS.md reference: AGENTS.md:L87-L87 Useful? React with 👍 / 👎. |
||
| # pnpm_config_verify_deps_before_run raw from the environment, and the | ||
| # npm_config_ spelling is silently ignored. | ||
| env: | ||
| pnpm_config_verify_deps_before_run: "false" | ||
|
|
||
| jobs: | ||
| dedupe-check: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -29,7 +39,7 @@ jobs: | |
| - name: Setup Node.js | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version-file: "package.json" | ||
| node-version-file: ".node-version" | ||
| cache: "pnpm" | ||
|
|
||
| - name: Verify install secret | ||
|
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 26.5.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/knip@6/schema.json", | ||
| "entry": ["src/cli.ts", "types/**/*.d.ts"], | ||
| "project": ["src/**/*.ts", "types/**/*.d.ts"] | ||
| "project": ["src/**/*.ts", "types/**/*.d.ts"], | ||
| "ignoreDependencies": ["conventional-changelog-conventionalcommits"] | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This newly added seven-line comment block violates the repository requirement that comments remain one short line and avoid multi-line blocks. Retain only the non-obvious invariant—for example, that disabling automatic reinstalls preserves the hardened install flags—so the workflow remains compliant and maintainable.
AGENTS.md reference: AGENTS.md:L87-L87
Useful? React with 👍 / 👎.