Repository navigation
build(deps): raise the Go floor to 1.27.2, closing the GO-2026-6617 residual - #317
Merged
Merged
Conversation
…esidual 1.26.9 was accepted with a residual: a local build on Go 1.27.0 or 1.27.1 satisfies it and ships the vulnerable net/http. 1.27.2 excludes both vulnerable lines, but no staticcheck could read Go 1.27 export data. staticcheck 2026.2.2 (v0.8.2) now can, which was the trigger #316 named. gosec has no release that reads it (v2.29.0 included), so it is pinned to master commit d2b649e, as usher and sapper are. The new gosec flags the G703 in spaHandler that DECISIONS.md predicted; it is a false positive for the reason recorded there, and is annotated next to the call. Every gate was checked by exit code under go1.27.2: build, vet (both tag sets), make lint, make gosec, make vulncheck, make tidy-check, and go test -race. Closes #316 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #316. The trigger arrived: staticcheck 2026.2.2 (v0.8.2, 2026-10-12) "now supports the updated export data format used by Go 1.27.2".
Changes
go.mod,Dockerfile,web/Dockerfileand the README mention move from 1.26.9 to 1.27.2.STATICCHECK_VERSIONmoves from v0.8.1 to v0.8.2.GOSEC_VERSIONmoves from v2.28.0 to the master commitd2b649e. No release reads Go 1.27 export data, and that includes v2.29.0. It is the same pin as usher and sapper, and goes back to a tag via usher#146 and sapper#56.#nosec G703onos.Stat(fsPath)inspaHandler. This is the false positive DECISIONS.md predicted, and the comment carries the justification.Checklist from #316
go.mod, both Dockerfiles at 1.27.2, andSTATICCHECK_VERSION/GOSEC_VERSIONupdatedmake gosecfails on exactly that line (exit 2), and with it, exit 0.GOTOOLCHAIN=go1.27.2:go build,go vet(with and without-tags=integration),make lint(both variants),make gosec,make vulncheck,make tidy-check,go test -race ./.... All exit 0.Also checked: the API image builds from
golang:1.27.2-alpine.Not checked locally: integration tests (
-tags=integration) and the web image. CI runs both.🤖 Generated with Claude Code