Skip to content

feat: surface Cron collection state #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Joncallim wants to merge 1 commit into
base: codex/68-cron-provenance-api
Choose a base branch
from
Open

feat: surface Cron collection state #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/web/src/lib/demoData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,10 @@ const demoRuntimeMap: RuntimeMap = {
providerStates: [
{ slot: "network_infrastructure", state: "unavailable", lastAttemptMs: null, lastSuccessMs: null, lastDurationMs: null, consecutiveFailureCount: 0, dataRevision: null, statusReason: "initial" },
{ slot: "host_scoped", state: "unavailable", lastAttemptMs: null, lastSuccessMs: null, lastDurationMs: null, consecutiveFailureCount: 0, dataRevision: null, statusReason: "initial" },
{ slot: "cron", state: "unavailable", lastAttemptMs: null, lastSuccessMs: null, lastDurationMs: null, consecutiveFailureCount: 0, dataRevision: null, statusReason: "initial" },
{ slot: "systemd", state: "unavailable", lastAttemptMs: null, lastSuccessMs: null, lastDurationMs: null, consecutiveFailureCount: 0, dataRevision: null, statusReason: "initial" },
{ slot: "python_processes", state: "unavailable", lastAttemptMs: null, lastSuccessMs: null, lastDurationMs: null, consecutiveFailureCount: 0, dataRevision: null, statusReason: "initial" },
{ slot: "native_processes", state: "unavailable", lastAttemptMs: null, lastSuccessMs: null, lastDurationMs: null, consecutiveFailureCount: 0, dataRevision: null, statusReason: "initial" },
{ slot: "systemd", state: "unavailable", lastAttemptMs: null, lastSuccessMs: null, lastDurationMs: null, consecutiveFailureCount: 0, dataRevision: null, statusReason: "initial" },
{ slot: "project_npm", state: "unavailable", lastAttemptMs: null, lastSuccessMs: null, lastDurationMs: null, consecutiveFailureCount: 0, dataRevision: null, statusReason: "initial" }
],
nodes: [
Expand Down
9 changes: 5 additions & 4 deletions apps/web/src/lib/model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,11 @@ describe("runtime collection evidence", () => {
const providerStates: RuntimeMap["providerStates"] = [
{ ...testProviderStates[0], state: "fresh", lastAttemptMs: 1, lastSuccessMs: 2, lastDurationMs: 1, dataRevision: "test-provider-1", statusReason: null },
{ ...testProviderStates[1], state: "stale", lastAttemptMs: 1, lastSuccessMs: 2, lastDurationMs: 1, consecutiveFailureCount: 1, dataRevision: "test-provider-2", statusReason: "collection_failed" },
{ ...testProviderStates[2], state: "collecting", lastAttemptMs: 3, statusReason: "refreshing" },
{ ...testProviderStates[3], state: "timed_out", lastAttemptMs: 3, lastSuccessMs: 2, lastDurationMs: 1, consecutiveFailureCount: 1, dataRevision: "test-provider-4", statusReason: "collection_timed_out" },
{ ...testProviderStates[4], state: "disabled", statusReason: "disabled" },
{ ...testProviderStates[5], state: "disabled", statusReason: "disabled" }
{ ...testProviderStates[2], state: "fresh", lastAttemptMs: 1, lastSuccessMs: 2, lastDurationMs: 1, dataRevision: "test-provider-3", statusReason: null },
{ ...testProviderStates[3], state: "collecting", lastAttemptMs: 3, statusReason: "refreshing" },
{ ...testProviderStates[4], state: "timed_out", lastAttemptMs: 3, lastSuccessMs: 2, lastDurationMs: 1, consecutiveFailureCount: 1, dataRevision: "test-provider-5", statusReason: "collection_timed_out" },
{ ...testProviderStates[5], state: "disabled", statusReason: "disabled" },
{ ...testProviderStates[6], state: "disabled", statusReason: "disabled" }
];
const model = buildModel(snapshot([]), { ...emptyRuntime, providerStates });

Expand Down
3 changes: 2 additions & 1 deletion apps/web/src/lib/testProviderStates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ function unavailableProviderState(slot: ProviderSlot): ProviderState {
}

/** Complete fixed-slot state used by browser-only fixtures. */
export const testProviderStates: [ProviderState, ProviderState, ProviderState, ProviderState, ProviderState, ProviderState] = [
export const testProviderStates: [ProviderState, ProviderState, ProviderState, ProviderState, ProviderState, ProviderState, ProviderState] = [
unavailableProviderState("network_infrastructure"), unavailableProviderState("host_scoped"),
unavailableProviderState("cron"),
unavailableProviderState("systemd"),
unavailableProviderState("python_processes"), unavailableProviderState("native_processes"),
unavailableProviderState("project_npm")
Expand Down
3 changes: 2 additions & 1 deletion apps/web/src/screens/Runtime.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const LAYER_LABEL: Record<RuntimeLayerId, string> = {
const PROVIDER_SLOT_LABEL: Record<ProviderSlot, string> = {
network_infrastructure: "Network infrastructure",
host_scoped: "Host-scoped services",
cron: "Cron schedule declarations",
systemd: "systemd services",
python_processes: "Python processes",
native_processes: "Native processes",
Expand Down Expand Up @@ -298,7 +299,7 @@ export default function RuntimeScreen() {
<Panel
title="Collection evidence"
icon="history"
hint="Collection state only — it does not describe service health"
hint="Collection state only — it does not describe service health or cron execution"
className="provider-state-panel"
>
<ul className="provider-state-list" aria-label="Provider collection evidence">
Expand Down
6 changes: 4 additions & 2 deletions apps/web/src/screens/runtime-provider-states.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const runtime: RuntimeMap = {
providerStates: [
collectionState("network_infrastructure", "fresh"),
collectionState("host_scoped", "stale", { consecutiveFailureCount: 1, statusReason: "collection_failed" }),
collectionState("cron", "fresh"),
collectionState("systemd", "collecting", { lastSuccessMs: null, lastDurationMs: null, dataRevision: null, statusReason: "refreshing" }),
collectionState("python_processes", "timed_out", { consecutiveFailureCount: 1, statusReason: "collection_timed_out" }),
collectionState("native_processes", "disabled", { lastAttemptMs: null, lastSuccessMs: null, lastDurationMs: null, dataRevision: null, statusReason: "disabled" }),
Expand All @@ -45,10 +46,11 @@ describe("Runtime collection evidence", () => {
const html = render();

expect(html).toContain("Collection evidence");
expect(html).toContain("Collection state only — it does not describe service health");
expect(html.match(/class="provider-state-row /g)).toHaveLength(6);
expect(html).toContain("Collection state only — it does not describe service health or cron execution");
expect(html.match(/class="provider-state-row /g)).toHaveLength(7);
expect(html).toContain("Network infrastructure");
expect(html).toContain("Host-scoped services");
expect(html).toContain("Cron schedule declarations");
expect(html).toContain("systemd services");
expect(html).toContain("Python processes");
expect(html).toContain("Native processes");
Expand Down
Loading