Repository navigation
Bound the wrapped-array release test by rounds, not seconds - #1187
Merged
Merged
Conversation
The test waited up to 10 s of wall-clock time for a wrapped host array to be collected, which stalled CI workers on MI250 exceeded twice (#1162, #1185), while the release itself only needs two collections with a device round trip in between: the first finalizes the wrapper, whose finalizer enqueues a host function on the stream; the device reaching it wakes the task that lets go of the array; the second collects the array. Make that round trip explicit by synchronizing the stream each round, and bound the wait by rounds instead, so a slow node can no longer fail it. On MI250X every run completes in exactly two rounds, idle or with all cores busy. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
AMDGPU.jl BenchmarksDetails
This comment was automatically generated by workflow using github-action-benchmark. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Wrap Array" test in
test/core/rocarray_base.jlwaits for a wrapped host array to be collected once the device is done with it. It bounded that wait by 10 s of wall-clock time, which stalled MI250 CI workers exceeded twice while everything else was green (#1162 on 2026-10-16, #1185 on 2026-10-23). In both runs that file took ~240 s instead of ~35 s, a known pattern on that partition.The release needs two collections with a device round trip in between: the first finalizes the wrapper, whose finalizer enqueues a host function on the stream; the device reaching it wakes the task that lets go of the array; the second collects the array itself. The test now synchronizes the stream each round, so the device step is explicit, and bounds the wait by rounds rather than by time. It can only fail if the array is genuinely never released.