Repository navigation
Test assigning through multi-dimensional masks - #818
Merged
Merged
Conversation
The logical indexing tests only assigned through a vector mask. A mask of a matrix goes through a SubArray of CartesianIndex instead, which is what failed in oneAPI.jl#461 when the indices stayed on the host. Also cover a mask mixed with a colon, plain setindex! through a mask, and check that a view by mask keeps its indices on the device.
maleadt
added
ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logical indexing tests only assigned through a vector mask. Assigning through the mask of a matrix (
A[A .== 0] .= 1) goes through aSubArrayindexed byCartesianIndexinstead, which is what failed in JuliaGPU/oneAPI.jl#461 back when the indices stayed on the host. This adds that case, a mask mixed with a colon (A[:, m] .= 0), plainA[m] = B[m], and a check thatview(A, mask)keeps its indices on the device.With the 2-arg
to_indicesoverride disabled, all of the new tests fail on oneAPI.