Repository navigation
Remove KA 0.9 compat and clean up generic_matmatmul implementation - #827
Open
christiangnrd wants to merge 5 commits into
Open
christiangnrd wants to merge 5 commits into
christiangnrd wants to merge 5 commits into
Conversation
christiangnrd
added this pull request to stack #828
October 19, 2026 21:03
christiangnrd
removed this pull request from stack #828
October 20, 2026 14:36
christiangnrd
added this pull request to stack #830
October 20, 2026 14:36
christiangnrd
force-pushed
the
noka0.9
branch
6 times, most recently
from
October 21, 2026 14:27
67d0704 to
79012cf
Compare
christiangnrd
force-pushed
the
noka0.9
branch
from
October 22, 2026 14:34
79012cf to
0b309e0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting KA 0.10 means the code can be cleaner. I changed if to use KI directly. That's not necessary, but KA isn't really needed here since it should always be launched with 2 dimensions.
The tile padding makes performance worse on metal and CUDA (on CUDA it prevents vectorization), so I also remove that. To be revisited if the
TILE_DIMis ever changed