Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
+ Coverage 87.73% 88.88% +1.15%
==========================================
Files 18 18
Lines 1737 1746 +9
==========================================
+ Hits 1524 1552 +28
+ Misses 213 194 -19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
On devices without SPIR-V support, every kernel was translated by writing the module to a temporary file and running the spirv2clc tool on it. Call the C API that spirv2clc_jll 0.2.6 provides in libspirv2clc instead, which avoids a process spawn per kernel. Diagnostics are delivered through a callback and logged once the call has returned, and errors keep the existing failure message with a dump of the offending module.
maleadt
force-pushed
the
tb/added-c-api-spirv2clc-0d4beb01
branch
from
October 21, 2026 05:02
c19b785 to
cc99cd7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the C API added in JuliaGPU/spirv2clc#27 to translate SPIR-V in-process, replacing the temporary input file and per-kernel subprocess. Requires
spirv2clc_jll0.2.6.The wrapper preserves the SPIR-V and OpenCL C target versions and failure dumps, copies the returned source into Julia, and frees both library-owned strings in
finally. Diagnostics are collected separately from source; warnings and remarks are logged after the C call returns, and errors appear in the translation exception.Validated on macOS arm64 with Julia 1.13.2 and PoCL 7.2: all 80 assertions in
poclc/executionandpoclc/translationpass, plus a kernel execution smoke test withprogram_backend!(:opencl). The new tests compare source with the CLI for OpenCL C 1.2, 2.0 and 3.0 and cover malformed input, unsupported versions, translator diagnostics and failure dumps. Other platforms and the full suite remain for CI.