Repository navigation
Query binaries of an unbuilt program in the tests again - #577
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 18 18
Lines 1737 1737
=======================================
Hits 1524 1524
Misses 213 213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoCL used to reject querying the binaries of a program created from binaries until it was built, so 0a6012e built that program before the query. pocl_jll 7.2.2+8 carries pocl/pocl#2379, which fixes this (#537), and the spec allows the query, so the test now checks that binaries round-trip without a build.
Passes locally on PoCL (
poclandpoclc), Intel's CPU runtime and NVIDIA.