Repository navigation
Test KernelAbstractions launches by their behavior, not the launch kind - #582
Merged
Merged
Conversation
The launch configuration tests asserted which kind of launch KernelAbstractions picks for a few shapes. That is KernelAbstractions' policy, not something the back end controls, and the assertions break whenever it changes (JuliaGPU/KernelAbstractions.jl#912 launches 4-d ranges on the N-d grid). Keep the checks of what the back end does affect: that a dynamic 3-d range is indexed without divisions, and that iteration spaces too large for 32-bit indices are indexed correctly, now also one that is only large along its last dimension.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 89.30% 89.30%
=======================================
Files 18 18
Lines 1748 1748
=======================================
Hits 1561 1561
Misses 187 187 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launch configuration tests asserted which kind of launch KernelAbstractions picks for a few shapes. That choice is KernelAbstractions' policy, not something the back end controls, and the assertions break whenever it changes: JuliaGPU/KernelAbstractions.jl#919 launches 4-d ranges on the N-d grid, which fails them on every back end.
This keeps the checks of what the back end does affect: that a dynamic 3-d range is indexed without divisions, and that iteration spaces too large for 32-bit indices are indexed correctly. The latter now covers a 4-d range that is launched on the N-d grid with JuliaGPU/KernelAbstractions.jl#919, and one that is only large along its last dimension.
The tests pass with KernelAbstractions main and with JuliaGPU/KernelAbstractions.jl#919, so this can be merged first.