Skip to content

Test Int16 reductions whose map overflows #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Oct 8, 2026
Merged

Test Int16 reductions whose map overflows #674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test/array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,18 @@ end
end
end

@testset "narrow integer reduction with overflowing map" begin
# IGC < 2.34.4+2 kept the result of a 16-bit `mad` in the accumulator at full width, so
# the signed `max` compared the unwrapped value (JuliaGPU/oneAPI.jl#670, TGL and DG2).
A = Complex{Int16}[22264-2672im -3184-13367im 20267+16808im -29600+21497im;
-2+6036im -13334-32552im -4391+23096im 1804+13481im;
-19764+32524im 20734-5522im 30645+17973im 21749-26470im]
mk = A -> view(permutedims(A), [1, 2, 3, 4], :)
R = Base.mapreducedim!(abs2, max, zeros(Int16, 1, 3), mk(A))
dR = Base.mapreducedim!(abs2, max, oneArray(zeros(Int16, 1, 3)), mk(oneArray(A)))
@test Array(dR) == R
end

@testset "mapreducedim! returning same type" begin
R = transpose(oneAPI.zeros(Float32, 2, 3))
A = oneArray(rand(Float32, 3, 2, 10))
Expand Down
Loading