Repository navigation
feat: add guide comparison check to browser Guided Setup (#175 step 8, slice 3) - #249
Merged
Merged
Conversation
…, slice 3) Add a Guides row to the Checks list that says whether the enabled guides agree on their shared channels. Report only: nothing hashed, never blocks accept. The candidate command returns the parsed programmes as one extra property after the manifest is sealed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NzHAckAcs78Lu3rv8Gqgrf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 3 of docs/planning/GUIDED-SETUP-BROWSER-DESIGN-NOTE.md (issue #175 steps 7 and 8). Report only.
guidesrow in the browser Checks list: "Your guides agree on their shared channels. Looks fine." or "Your guides disagree on N programmes. You can accept, or fix this first (see Details)." Details (hidden until the Details button) are the existing xguide summary lines.New-ChannelForgeCandidateProposalFromSourceSetreturns the parsed programmes as one extra property, added after the manifest is sealed. It is not written to disk, hashed, put in the session or sent to the browser.CanAccept,BlockingReasons, candidate hash and session file are unchanged. A Pester test compares the sealed hash andCanAcceptwith and without the checks. Frozen contracts untouched.About 20 product lines. Verified locally: GuidedSetupChecks 6 passed, WebServer 50 passed, SourceRefreshCandidate 6 passed, vitest guided-setup-browser 11 passed,
npm run typecheckclean (Node 26 / npm 12 locally; CI uses Node 22). The full suite runs in CI.Known limits: Details name guides by their internal source id, not the label; the count is the report's total difference count; no playlist scoping yet.
Part of #175.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NzHAckAcs78Lu3rv8Gqgrf