Repository navigation
fix: redact more secret shapes in guide safe text (#175) - #251
Merged
Merged
Conversation
Also redact compound secret names, Authorization and Bearer values, and e-mail addresses, and Unix paths under well-known roots, in guide free text. Normal event titles such as Round 1/Final and WWE Raw 8/7c pass through unchanged. Signature, bounds and callers unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NzHAckAcs78Lu3rv8Gqgrf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes only the safe-text hardening from draft #205, as its own small change, before event titles go into guides.
ConvertTo-ChannelForgeGuideSafeTextnow also redacts compound secret names (for exampleapi_key=...), Authorization and Bearer values, e-mail addresses, and Unix paths that start at /home, /users, /root, /var, /etc, /usr, /opt, /tmp, /mnt or /srv. Windows paths were already handled.tests/unit/GuideSafeText.Tests.ps1(14 tests): real event titles pass through unchanged (UFC 300: Main Card, Round 1/Final, Night 1 / Night 2, WWE Raw 8/7c, PPV 1 - Fight Night, Home/Away Highlights); secrets are redacted.Verified locally with Pester under pwsh, one file at a time, 0 failed: GuideSafeText 14, OneGuide 14, CategoryReport 6, CategoryProgrammeCheck 3, GuideIntelligence 12, GuidePatternInference 11, GuidePatternReview 8, GuidePatternAcceptancePlan 14. Not verified: full suite (CI runs it).
Part of #175.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NzHAckAcs78Lu3rv8Gqgrf