KC-1427: Add NSF folder support to list-sf --roe-eligible - #2323
Open
sshrushanth-ks wants to merge 2 commits into
Open
KC-1427: Add NSF folder support to list-sf --roe-eligible#2323sshrushanth-ks wants to merge 2 commits into
sshrushanth-ks wants to merge 2 commits into
Conversation
Add search_nested_share_folders() helper and extend RecordListSfCommand to include NSF folders with PAM User rotation in --roe-eligible results. Enables integrations (Slack, Google Chat) to detect PAM eligibility on NSF folders.
sshrushanth-ks
changed the title
Gate NSF search behind --roe-eligible flag; add folder_type column ('Classic'
or 'Nested') to enable integrations to distinguish classic vs NSF folder UIDs.
Includes test coverage.
sshrushanth-ks
changed the title
sshrushanth-ks
marked this pull request as ready for review
August 27, 2026 08:19
sshrushanth-ks
requested review from
amangalampalli-ks,
pvagare-ks and
sali-ks
August 27, 2026 09:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrations (Slack, Google Chat) detect PAM eligibility via
list-sf --roe-eligible --format=json, but the command only searched classic Shared Folders, returning "No shared folders are found" for Nested Share Folders even when they contained PAM User records with rotation configured. Now--roe-eligibleincludes NSF folders in results with a newfolder_typecolumn ('Classic' or 'Nested') so integrations can distinguish between folder types and route to the correct command (share-foldervsnsf-share-folder).Changes
keepercommander/api.py: Addedsearch_nested_share_folders()helper mirroringsearch_shared_folders()to search NSF folders by UID/namekeepercommander/commands/record.py: ExtendedRecordListSfCommand.execute()to search NSF folders only when--roe-eligibleis set; addedfolder_typecolumn ('Classic'/'Nested') to both JSON and table outputunit-tests/test_api.py: Addedtest_search_nested_share_folders()with 6 test cases (empty search, token match, UID match, no match, missing attribute, empty cache)unit-tests/test_command_record.py: Addedtest_shared_list_nsf_only_when_roe_eligible()verifying NSF gating behavior; addedtest_shared_list_folder_type_column()verifying output formatFixes:
list-sf <nsf_uid> --roe-eligiblenow returns NSF folders with PAM User rotation configured