Repository navigation
Give doctor's --config axis flag its own attribute (4.0.0-B2) - #16
Merged
Merged
Conversation
The --config axis flag and the loaded config both lived on args.config.
Bare `sysforge doctor` read the loaded dict as the flag and ran only the
config axis; `doctor system` read the flag's False as an already-loaded
config and ran every axis against {}. The flag now stores to config_axis;
its spelling is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KeithRaghubar
force-pushed
the
fix/doctor-hang
branch
from
October 30, 2026 21:21
08086b4 to
e21eb37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--configaxis flag (3.5.0-F18) and the loaded config both lived onargs.config:sysforge doctorread the loaded config as the flag and ran only the config axis. It printed one section and exited, which looked like a hang.sysforge doctor systemread the flag'sFalseas an already-loaded config and ran every axis against{}, so the toolchain, cache, graphics and storage checks ignored the live config.The flag now stores to
config_axis. Its spelling is unchanged, so completions, the man page andsurface.jsonare untouched.Test tier
Unit tests are enough here. The bug is argparse wiring plus
pre_check, and the new tests drive the real parser (cli_args) andpre_checkwith a non-empty config. The existing_make_argshelper passesconfig={}, which is falsy and hid the collision.Testing
tests/test_doctor.py, all failing before the fixsysforge doctornow renders all 14 default axes in about 13 sMerge order
Merge #15 first: it holds
4.0.0-B1, and until it mergescheck-standardswarns about the gap at B1. Both PRs add a## Fixedsection todocs/release-notes/unreleased.md, so this branch needs a small rebase after #15 merges: keep one heading with B1 before B2.🤖 Generated with Claude Code