Update dependencies, restore CI test discovery - #246
Open
KevinBatdorf wants to merge 7 commits into
Open
Conversation
WP Playground intermittently 500s or crashes mid-test in CI across the sibling block repos, sending false-alarm failure emails while the rest of the matrix passes. One CI retry absorbs those one-offs; a real regression still fails after the retry. Local runs keep retries: 0 to fail fast while iterating. Update the testing rules, which previously banned retries outright, to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Moving the shared blueprint to tests/ (bb14f1e) updated playwright.config.ts to walk up from each spec, but the local runner and both workflow discover jobs still required blueprint.json in the spec's own directory. Since that commit they silently dropped the at-rules and default suites — CI has been running 3 of 13 tests while reporting green. All three discovery sites now implement the same walk-up as the config. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The front-end check ran against page.content(), but Twenty Twenty-Five inlines its own @font-face for Manrope and Fira Code, so the not-toContain assertion could never pass (and toContain('@media') passed vacuously from theme CSS). The rewrite landed while discovery was dropping this suite, so it never actually ran. Assert on the style#pcss-block-* element the plugin registers instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ncu with the repo's own reject list honored: shiki stays on 0.14.7 (setCDN/setWasm and the vendored build/shiki assets don't exist in shiki 1+; migrating is its own project) and tailwindcss stays on 3.4 (v4 removed tailwindcss/nesting from exports, which postcss.config.js loads). Everything else moves: wp-scripts 34, typescript 7, block-editor 16, lightningcss 1.33, biome 2.5, playwright 1.62, playground CLI 3.1.48. Removed the deprecated @types/wordpress__blocks stub and its tsconfig types entry. typescript 7 removed moduleResolution node (now bundler) and requires declarations for side-effect CSS imports (src/types/css.d.ts). The stricter zustand types surfaced string defaults sitting in number-typed state in both stores — now numbers. Build, lint, tsc pass; 13/13 e2e on latest and nightly (with discovery fixed in the previous commit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The formatter update rewraps a handful of expressions; without this biome check fails on a clean tree. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Locks written by npm 11.6 fail npm ci validation on CI's newer npm (wasm-variant optional deps resolve differently) — regenerated from scratch and verified npm ci passes. Biome $schema now points at the installed package, and actions/cache v5 clears the runner's node20 deprecation warning. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two finds beyond the version bumps:
tests/— the local runner and both workflow discover jobs still required a same-dirblueprint.jsonwhile onlyplaywright.config.tsgot the walk-up. All three discovery sites now walk up identically.at-rulessuite (silently skipped until now) asserted on the whole page, which always contains Twenty Twenty-Five's own@font-face— it now asserts on the plugin'sstyle#pcss-block-*element.Deps:
ncuhonoring the repo's own reject list — shiki 0.14.7 (v1+ removedsetCDN/setWasmand the vendoredbuild/shikiassets) and tailwindcss 3.4 (v4 removedtailwindcss/nesting) stay. Everything else moves: wp-scripts 34, typescript 7, block-editor 16, lightningcss 1.33, biome 2.5, playwright 1.62. The stricter zustand types surfaced string defaults in number-typed store state — now numbers.13/13 e2e on latest and nightly. Stacks on #245 — merge that first.
🤖 Generated with Claude Code