Stabilize balance fixture CI budget - #84
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70474bb252
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // This deterministic fixture simulates four complete seasons serially. A | ||
| // cold GitHub runner can exceed five minutes as the live worker gains new | ||
| // season systems, so preserve the full sample instead of truncating proof. | ||
| }, 600_000); |
There was a problem hiding this comment.
In environments where this fixture is as slow as the current worktree, the new ceiling still does not stabilize CI: I ran pnpm --filter @mbd/web exec vitest run src/workers/sim.worker.balance.test.ts --reporter=verbose, and Vitest failed at this beforeAll with Hook timed out in 600000ms after 622.14s, skipping all 9 balance assertions. Since .github/workflows/ci.yml runs the web tests via MBD_SKIP_SMOKE_GATE=1 pnpm verify, this changed timeout can still block the normal verify step while burning ten minutes; the fixture needs to finish under the budget or be split/moved out of the default CI path rather than only raising the cap.
Useful? React with 👍 / 👎.
1 participant
What changed
The deterministic balance fixture keeps both seeds and all four simulated seasons, while its single
beforeAllbudget increases from 300 seconds to 600 seconds for cold GitHub runners.Root cause
Current-main CI passed 472 web test files and 2,469 tests, but this fixture reached the exact five-minute hook ceiling before its assertions could run. No gameplay assertion, determinism check, or build failed.
Impact
Test-only. Simulation behavior, seeds, acceptance bands, save compatibility, and production bundles are unchanged.
Validation
git diff --cached --checkpassed