Add default constructor to nd_range - #1046
Conversation
The range and id classes are default constructible, but nd_range is not: its only constructor requires the global and local ranges, which a user may not know at the point where the nd_range object has to be created. Add nd_range() noexcept, which default constructs the global range, the local range and the (deprecated) offset, so that every component is 0. Fixes KhronosGroup#1043
In the nd_range synopsis the /* -- common interface members -- */ marker sat above the globalSize/localSize/offset constructor, so that constructor appeared to be part of the common interface. In the range and id synopses all constructors are listed before the marker and only the members of the common interface follow it. Move the marker below both constructors to match. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
We just need one more approval, then we can more both this on the CTS :) |
|
@TApplencourt what person do we need to give an approval, some third party, e.g. non-Intel and non-ANL? |
|
Exactly. |
|
@VerenaBeckham @keryell could you please take a look? |
|
@TApplencourt is Greg the only one with merge rights? |
|
He is our editor, so kinda : ) Do you have some kind of deadline or something? |
nope, just wondering as Greg is out of office for some time. |
|
Adding the Agenda label, so we can merge this in tomorrow's WG call. Did the WG decide that this is OK to merge as a SYCL 2020 errata? |
|
6 participants
The range and id classes are default constructible, but nd_range is not: its only constructor requires the global and local ranges, which a user may not know at the point where the nd_range object has to be created.
Add nd_range() noexcept, which default constructs the global range, the local range and the (deprecated) offset, so that every component is 0.
SYCL-CTS KhronosGroup/SYCL-CTS#1231
Fixes #1043