Clarify atomics memory model - #1047
Merged
Merged
Conversation
Cherry pick KhronosGroup#1032 from main (cherry picked from commit 4dc10b0)
The previous commit was cherry picked from the SYCL-Next branch, and it contains some information specific to SYCL-Next. Edit out this information, leaving only the parts relevant to SYCL 2020.
Contributor
Author
|
@VerenaBeckham, @TApplencourt: This PR to SYCL 2020 isn't a straight cherry-pick because I edited-out some SYCL-Next wording. Do you want it to be reviewed before merging, or do you want me to merge as editorial? You can see the edits I made in 6184a01. |
Contributor
|
LGTM! I think we can merge is as editoral. The change to adapt the text for the SYCL 2020 branch seem obvious. But just in case, maybe we can wait a little bit for @VerenaBeckham thumbs-up :) Thanks |
Contributor
|
Thanks, the changes for the SYCL 2020 spec look good to me also! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick #1032 from main (with some edits to remove SYCL-Next stuff)
(cherry picked from commit 4dc10b0)