Repository navigation
Prepare AC7 and Project Wingman observer 0.1.1 prereleases - #4
Conversation
Fix VS2022 constant-template warnings, align component versions and add allowlisted packages with complete notices. See docs/releases/v0.1.1-windows.md for build, SDK fixture evidence and explicit gameplay limits.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afa98a2d00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (args.fidelityfx_root / "Kits/FidelityFX/signedbin/amd_fidelityfx_loader_dx12.dll", | ||
| "ReScaleFrame/fidelityfx/amd_fidelityfx_loader_dx12.dll"), |
There was a problem hiding this comment.
When the local FidelityFX tree contains the validated upscaler but a stale or replaced amd_fidelityfx_loader_dx12.dll, the existing check on fsr still passes and this file is copied into a release that is presented as the matched SDK 2.3.0 runtime set. The manifest only records whatever was copied, so it cannot detect this pre-packaging mismatch, and the resulting package can fail when the signed FidelityFX components load their companion loader. Add the loader's expected SHA-256 to the validation loop before staging it.
Useful? React with 👍 / 👎.
| ("build/windows-x64/wingman/bin/Release/xinput1_3.dll", "xinput1_3.dll"), | ||
| ("build/windows-x64/bin/Release/ReScaleFrame.Runtime.dll", "ReScaleFrame/ReScaleFrame.Runtime.dll"), | ||
| ("build/windows-x64/bin/Release/ReScaleFrame.Game.ProjectWingman.dll", "ReScaleFrame/ReScaleFrame.Game.ProjectWingman.dll"), |
There was a problem hiding this comment.
If build/windows-x64 still contains outputs from an earlier revision, the clean-tree check passes because build/ is ignored and these three stale or partially rebuilt DLLs are packaged without any version or expected-hash validation. The generated manifest nevertheless labels them with the current VERSION and HEAD, so a nominal 0.1.1 archive can contain mismatched components and fail its ABI or report the wrong source provenance. Validate the three binaries against the intended release build before copying them.
AGENTS.md reference: AGENTS.md:L36-L38
Useful? React with 👍 / 👎.
A constant-OK quiesce lambda triggers C4127 after the enqueue fix. Switch on the result to preserve lifecycle refusal behavior. Release verify and existing plugin lifecycle contracts pass; see docs/releases/v0.1.1-windows.md.
Preserve export checks and real failures; only missing system XInput returns 77. Local forwarding and Release verify pass. See docs/releases/v0.1.1-windows.md for the clean-runner failure and evidence limits.
Prepare separate Windows 0.1.1 previews from matched components. AC7 packages current SR/FG/latency code and retail SDK payloads; Project Wingman packages its existing exact-build temporal observer, with no SR/FG/latency/VR claims. Add its allowlisted packager/install guide, include the AMD loader and MFG-Unlocker notice in AC7, and correct VS2022 C4127 warnings in the AC7 enqueue/lifecycle templates without changing behavior.
Validation: SDK-enabled VS2026/MSVC Release verification passed 44 native tests with eight opt-in skips, Rust formatting/Clippy and all 59 Rust tests. Release overlay builds. Explicit RTX 5080 SR pipeline, disabled-FG provider ownership switching and Reflex API fixtures passed. Packaged AC7 startup, Wingman XInput forwarding and real Rust overlay rendering passed. Both packagers verify ZIP CRC and every manifest file hash; uploaded asset digests are checked against local files. No fresh game/VR/enabled-FG cadence/physical latency acceptance. See docs/releases/v0.1.1-windows.md for rationale and evidence.