Repository navigation
Word fixes from the reporters' files: header page counts, default font, page breaks, frames - #1534
Merged
Merged
Conversation
… renderer (#1152) A PAGE or NUMPAGES field in a table of a first-page header kept the number Word last saved ("Page 1 of 2" in a three-page document), because rhwp leaves such a number blank. The field is now read as a page number that also holds Word's text: the renderer counts the pages, and the HWPX writer still writes Word's text for rhwp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…1180) When a document's defaults and styles name no font at all, Word draws its Latin and complex-script text in Times New Roman. The renderer fell back to its own sans serif, which is wider: one of the worksheets ran two pages longer. Documents that name a font or a theme font keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ng page break (#1194) A paragraph that ends right after its page break keeps its mark on the old page in Word. The reader made that empty rest a paragraph of its own at the top of the new page, so every chapter after such a break started a line and the paragraph's space after lower, and long reports ran pages over. The next paragraph or table now starts the page instead. A numbered paragraph or one that ends a section keeps its rest as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es (#1313) - A VML shape with visibility:hidden (a form's spare copy of its WordArt) was drawn, squeezed into its 50 pt box over the title. - A paragraph in a frame (w:framePr) placed on the page or within the margins stayed in the text: the form's verification code came out under the signature in the middle of the page. Such paragraphs now go into a box of the frame's size at its place, floating at the paragraph before them, so they take no room in the text. Frames that move with the text and drop caps stay as they were. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'s blue (#1152) Word writes each entry of a table of contents as a link in the Hyperlink character style, yet draws the entries in the TOC styles' look, as LibreOffice does. The renderer drew every entry blue and underlined. In a TOC field's result the Hyperlink character style is now left out; links elsewhere keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found by running the reporters' own files of #1180, #1313, #1194, #1152, #993, #1315 and #979 through the built-in engines and comparing with Word's or PowerPoint's PDF where the reporter attached one, and with LibreOffice 26.2 otherwise. No reporter file is in the repository: every test builds its document in code.
#1152: header page numbers and table of contents
HField.Stored). The renderer counts the pages; the HWPX writer still writes Word's text, so the rhwp route is unchanged.#1180: documents that name no font
#1194: page breaks at the end of a paragraph
#1313: hidden shapes and frames
visibility:hiddenwas drawn. The form's spare copy of its WordArt came out squeezed over the title.w:framePr) placed on the page or within the margins stayed in the text. The verification code came out under the signature instead of at the bottom right.Checked, nothing to change here
Tests
ReportedCasesTests:Issue1152_page_x_of_y_in_a_first_page_header_table_counts_every_pageIssue1152_table_of_contents_entries_are_not_drawn_as_blue_linksIssue1180_text_in_a_document_that_names_no_font_is_in_times_new_romanIssue1194_a_page_break_at_the_end_of_a_paragraph_leaves_no_empty_line_on_the_next_pageIssue1313_a_frame_sits_where_its_page_position_puts_itWordWatermarkTests:A_hidden_wordart_shape_is_left_out.Filee.Engines.Testsrun: 405 passed, 23 skipped, 1 failed.OcrTests.A_scanned_pdf_becomes_a_docx…(a missing temp path). It passes when run alone.dotnet format Filee.slnx --verify-no-changes --severity warnis clean.🤖 Generated with Claude Code