Skip to content

Compatibility With Charm #32

Closed
Closed

Description

@Kasprenius

The title says it, for some reason I can't load charm and this together ;-; this is one of my favorite mods! Please save me!!

Activity

  1. KrisCris commented on Jun 13, 2022

    @KrisCris
    Owner

    Crash log, or any link to the mod?

  2. archiveduser92131 commented on Jun 14, 2022

    @archiveduser92131

    Can confirm, my game launches fine if charm is disabled with allstackable enabled, and vice versa.
    Crash log when both mods are enabled here: https://paste.ee/p/nR4ko
    Charm Mod on CurseForge

  3. Kasprenius commented on Jun 14, 2022

    @Kasprenius
    Author

    I actually think I know the issue, charm has its own stack modifier modules, haven’t tried yet but maybe disabling them will let Allstackable work! Or not, but what charm lets me modify is really all I wanted to anyways 😂

  4. KrisCris commented on Jun 14, 2022

    @KrisCris
    Owner
    
    [00:37:48] [main/WARN]: @Redirect conflict. Skipping charm.mixins.json:stackable_enchanted_books.FixAnvilBookStackMixin from mod charm->@Redirect::anvilUpdateHook(Lnet/minecraft/class_1263;ILnet/minecraft/class_1799;)V with priority 1000, already redirected by allstackable.mixins.json:MixinAnvilScreenHandler from mod allstackable->@Redirect::decrementOne(Lnet/minecraft/class_1263;ILnet/minecraft/class_1799;Lnet/minecraft/class_1657;Lnet/minecraft/class_1799;)V with priority 1000
    
    
    Critical injection failure: Redirector anvilUpdateHook(Lnet/minecraft/class_1263;ILnet/minecraft/class_1799;)V in charm.mixins.json:stackable_enchanted_books.FixAnvilBookStackMixin from mod charm failed injection check, (0/1) succeeded.
    

    Both mods are trying to fix issues related to stacked enchanted books using on Anvil, probably that’s the reason

    Update: Also the potion fix

  5. AstraDrift commented on Jul 6, 2022

    @AstraDrift

    Fixed this by deleting anything related to stacking in charm jar (svenhjol/charm/mixin/ stackable folders) and also mixins json. Now both mods work. MC 1.18.2 Fabric
    Not really a fix, I know

  6. KrisCris commented on Jul 11, 2022

    @KrisCris
    Owner

    Fixed this by deleting anything related to stacking in charm jar (svenhjol/charm/mixin/ stackable folders) and also mixins json. Now both mods work. MC 1.18.2 Fabric Not really a fix, I know

    This is definately a workaround, tho far from perfect lol. I need to figure out how to conditionally disable a mixin.

    In the meantime, MAYBE instead of deleting all mixins and the json file, you can try comment out certain line of mixins (e.g. FixAnvilBookStackMixin) in that json file.
    e.g.

    1. Open the .jar file with an zip browser
    • image
    1. open charm.mixins.json with any text editor

    2. remove these three lines of code:

    • image
  7. SnowedInOwl commented on Jul 19, 2022

    @SnowedInOwl

    So is this being worked on?

  8. chimericdream commented on Jul 27, 2022

    @chimericdream
    Contributor

    I need to figure out how to conditionally disable a mixin.

    I had to do this recently, and it turned out to be much simpler than I expected. You need a mixin plugin. Here's mine.

  9. KrisCris commented on Jul 27, 2022

    @KrisCris
    Owner

    So is this being worked on?

    Yes and no... I was trying to make it working but the game keeps crashing when I launch it via IntelliJ. So I put it aside and enjoyed playing MHRiseSunbreak with my friends for almost the entire month.. LOL

    I promise you I will figure it out soon :)

  10. KrisCris commented on Jul 27, 2022

    @KrisCris
    Owner

    I need to figure out how to conditionally disable a mixin.

    I had to do this recently, and it turned out to be much simpler than I expected. You need a mixin plugin. Here's mine.

    Thanks man, this is really HELPFUL! Finally know how to enable the plugin in mixins.json 😂

    Btw, do you know how to run Minecraft from the IDE with other mods, like charm?

  11. SnowedInOwl commented on Jul 27, 2022

    @SnowedInOwl

    Ok nice LOL that sounds like something I've done but with Valorant

  12. KrisCris commented on Jul 27, 2022

    @KrisCris
    Owner

    Ok nice LOL that sounds like something I've done but with Valorant

    Can you test if the mod is now compatible with Charm? @SnowedInOwl

    AllStackable-v1.5.6_CharmCompat-3-1.19.zip

  13. KrisCris commented on Jul 27, 2022

    @KrisCris
    Owner
  14. KrisCris commented on Jul 27, 2022

    @KrisCris
    Owner

    But I really think Charm should disable their anvil fix when allstackable is loaded cuz the latter includes more fixes on item usages on anvil.
    Original:

    • image

    Allstackable Fixes:

    • image
    • image
    • And rename vanilla stacakble items still working:
      • image

    Or you can just disable their mixins by doing these #32 (comment)
    charm-fabric-1.19-4.1.2_modified.zip

  15. SnowedInOwl commented on Jul 27, 2022

    @SnowedInOwl

    Ok nice LOL that sounds like something I've done but with Valorant

    Can you test if the mod is now compatible with Charm? @SnowedInOwl

    AllStackable-v1.5.6_CharmCompat-3-1.19.zip

    @KrisCris Sure sorry i was asleep when you asked but i can do that now

  16. SnowedInOwl commented on Jul 27, 2022

    @SnowedInOwl

    It works fine now @KrisCris

  17. chimericdream commented on Jul 28, 2022

    @chimericdream
    Contributor

    Btw, do you know how to run Minecraft from the IDE with other mods, like charm?

    Yep. Basically, you add the Maven repo for the mod in question, then add a modImplementation line in the dependencies. Here is my build.gradle file, where I'm doing that for a few dependencies. On occasion, I have added other mods (ones I want to add items for) to there to make it easier to test as I go.

  18. changed the title [-]Incompatibility With Charm[/-] [+]Compatibility With Charm[/+] on Jul 28, 2022
  19. Repository owner locked and limited conversation to collaborators on Jul 28, 2022
  20. converted this issue into a discussion #38 on Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions