Fix segmentation fault on invalid home-id in live command - #17
Merged
Conversation
- Use specific error messages for invalid home IDs - Refactor test file to use table-driven tests - Remove unsafe fmt.Errorf usage
pcriv
marked this pull request as draft
August 25, 2026 22:00
pcriv
marked this pull request as ready for review
August 26, 2026 06:25
Owner
|
Merging — thanks for the fix and especially for the tests. I verified this beyond the green check, since CI ran on 2026-08-25 against base
The fix is at the right layer. Three notes for the record, none blocking:
Minor nit for next time: the test struct field is named Closes #13. |
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13