Run original assertions during symbolic verification and validate generated harnesses - #1
Draft
KryptosAI wants to merge 3 commits into
Draft
Run original assertions during symbolic verification and validate generated harnesses#1KryptosAI wants to merge 3 commits into
KryptosAI wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed Foundry tests previously led to generated symbolic assertions that could lose the original setup and property. Run the original compiled tests under Halmos, retain exact test identities and counterexamples, and preserve a concrete fuzz violation even when symbolic execution disagrees or remains incomplete. Empty results, skipped tests, malformed path counts, timeouts and bounded loops cannot become successful verification.
Echidna and CVL exports now resolve concrete contract storage, report unsupported properties, and avoid tautological unsigned nonnegativity assertions. The Echidna regression executes the generated harness against correct and deliberately corrupt accounting. CI requires real Forge/Halmos integration and separately compiles the generated CVL with Certora without submitting a remote proof.
Both Forge and Halmos use native contract creation rather than Foundry 1.8's dynamic test linking, whose injected deployment cheatcode is unsupported by Halmos 0.3.3. Inconclusive bytecode checks retain their per-test status and diagnostic transcript.
Validation on this remote-main-based branch:
npm run test:cvlpasses with Certora CLI 8.19.1 and Solidity 0.8.24.Halmos results remain bounded by its configured exploration limits. Stateful invariant sequence replay is explicitly unsupported. Exported coverage can be partial; the example CVL covers solvency, and remote Certora proof is still pending service access.