Pass all command-line 'webtest' and 'webdriver' properties to tests - #249
Open
labkey-tchad wants to merge 2 commits into
Open
Pass all command-line 'webtest' and 'webdriver' properties to tests#249labkey-tchad wants to merge 2 commits into
labkey-tchad wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Low priority fix, can go in the next release
Command-line
webtest.*andwebdriver.*properties were only being passed through to tests inRunTestSuitewhen running on Teamcity. This moves the logic to the baseRunUiTesttask so that the properties are passed through outside of TeamCity as well.Related Pull Requests
Changes
webtest.*/webdriver.*system properties fromRunTestSuitetoRunUiTestDisableCachingByDefaultimport inRunUiTest