Fix handling of RECORD objects with variable subobjects - #83
Merged
Conversation
* Add"start_index" argument in "each" in jsonc format that informs the position of the shared sub objects
chrisinabox
approved these changes
Aug 20, 2026
chrisinabox
left a comment
chrisinabox
left a comment
Contributor
There was a problem hiding this comment.
Seems like a somewhat reasonable change to allow flexible use of the existing each objects. Curious if the lint.ignore flags will ever actually be fixed though.
Member
Author
|
Thanks. -- I have no immediate plans to fix the lint errors. The code is unchanged thou, its just the linter which has become more narrow (which is a good thing). If someone gets inspired to fix them, they are open to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue of having
RECORDobjects with variable length that caused the JSON read and write to crash.Add a new parameter
"start_index"in the"each"section of the json file format. When not present it will default to 1.Fixes #82