Fix Elements running status after startup - #1966
Draft
ekulkisnek wants to merge 1 commit into
Draft
ekulkisnek wants to merge 1 commit into
ekulkisnek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ListBinariesstatus when a managed binary has no dedicated Flutter RPC connectionWhy
The Elements sidechain is represented by
LiquidSignet, which is managed by orchestratord but has no dedicatedRPCConnection.BinaryProvidertherefore always reported it as disconnected even after orchestratord successfully launchedelementsd, leaving the sidechains page on Start.With this change, the Elements row follows the orchestrator's actual process status and changes to Launching… and then Stop after startup.
Validation
dart formatcompleted successfullygit diff --checkpassedsail_ui/lib/providers/binaries/binary_provider.dartPer request, no test was added.